Skip to content

feat(Webhook): allow setting withComponents#10792

Merged
kodiakhq[bot] merged 3 commits intodiscordjs:mainfrom
sdanialraza:feat/allow-setting-with-components
Mar 5, 2025
Merged

feat(Webhook): allow setting withComponents#10792
kodiakhq[bot] merged 3 commits intodiscordjs:mainfrom
sdanialraza:feat/allow-setting-with-components

Conversation

@sdanialraza
Copy link
Copy Markdown
Member

Please describe the changes this PR makes and why it should be merged:
Upstream:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 6:39pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 6:39pm

Copy link
Copy Markdown
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the brackets. This is for non-application-owned webhooks, so the "non-interactive" description is critical information.

...If I'm wrong, just ignore this.

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@sdanialraza sdanialraza requested a review from Jiralite March 5, 2025 15:47
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Mar 5, 2025
@kodiakhq kodiakhq bot merged commit b7e334e into discordjs:main Mar 5, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Mar 5, 2025
@sdanialraza sdanialraza deleted the feat/allow-setting-with-components branch March 5, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants