Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: standardize export style to named exports #10630

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This standardizes the export style across the codebase by replacing default exports with named exports for consistency. It was pointed out internally here.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2024 2:15pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2024 2:15pm

@sdanialraza sdanialraza force-pushed the refactor/standardize-export-style-to-named-exports branch from 6b99372 to d36072f Compare December 2, 2024 19:55
@sdanialraza sdanialraza marked this pull request as ready for review December 2, 2024 20:01
@sdanialraza sdanialraza requested a review from a team as a code owner December 2, 2024 20:01
@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Dec 3, 2024
vladfrangu
vladfrangu previously approved these changes Dec 5, 2024
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck testing this XD

didinele
didinele previously approved these changes Dec 5, 2024
@almeidx almeidx force-pushed the refactor/standardize-export-style-to-named-exports branch from a30e840 to b5fd7f7 Compare December 5, 2024 20:56
@sdanialraza sdanialraza marked this pull request as draft December 5, 2024 21:12
@almeidx almeidx dismissed stale reviews from didinele and vladfrangu December 5, 2024 21:15

Stale

@almeidx almeidx removed the in review label Dec 5, 2024
@sdanialraza sdanialraza force-pushed the refactor/standardize-export-style-to-named-exports branch from 9b09786 to c0f24ea Compare December 8, 2024 23:06
@sdanialraza sdanialraza force-pushed the refactor/standardize-export-style-to-named-exports branch from c0f24ea to 0cc4d9e Compare December 19, 2024 16:08
@almeidx almeidx self-requested a review December 21, 2024 22:34
@sdanialraza sdanialraza force-pushed the refactor/standardize-export-style-to-named-exports branch from 0cc4d9e to 12b2c58 Compare December 23, 2024 14:15
@sdanialraza sdanialraza marked this pull request as ready for review December 23, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

5 participants