-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: standardize export style to named exports #10630
Open
sdanialraza
wants to merge
5
commits into
discordjs:main
Choose a base branch
from
sdanialraza:refactor/standardize-export-style-to-named-exports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: standardize export style to named exports #10630
sdanialraza
wants to merge
5
commits into
discordjs:main
from
sdanialraza:refactor/standardize-export-style-to-named-exports
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
sdanialraza
force-pushed
the
refactor/standardize-export-style-to-named-exports
branch
from
December 2, 2024 19:55
6b99372
to
d36072f
Compare
vladfrangu
requested changes
Dec 3, 2024
vladfrangu
previously approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good luck testing this XD
didinele
previously approved these changes
Dec 5, 2024
almeidx
force-pushed
the
refactor/standardize-export-style-to-named-exports
branch
from
December 5, 2024 20:56
a30e840
to
b5fd7f7
Compare
sdanialraza
force-pushed
the
refactor/standardize-export-style-to-named-exports
branch
from
December 8, 2024 23:06
9b09786
to
c0f24ea
Compare
sdanialraza
force-pushed
the
refactor/standardize-export-style-to-named-exports
branch
from
December 19, 2024 16:08
c0f24ea
to
0cc4d9e
Compare
sdanialraza
force-pushed
the
refactor/standardize-export-style-to-named-exports
branch
from
December 23, 2024 14:15
0cc4d9e
to
12b2c58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This standardizes the export style across the codebase by replacing default exports with named exports for consistency. It was pointed out internally here.
Status and versioning classification: