feat: add eslint rule

discordjs · Dec 23, 2024 · 12b2c58 · 12b2c58
1 parent dc357b0
commit 12b2c58
Show file tree

Hide file tree

Showing 9 changed files with 56 additions and 42 deletions.
diff --git a/packages/discord.js/.eslintrc.json b/packages/discord.js/.eslintrc.json
@@ -198,9 +198,23 @@
             "name": "clearInterval",
             "message": "Import clearInterval from `node:timers` instead"
           }
+        ],
+
+        "no-restricted-syntax": [
+          "error",
+          {
+            "selector": "AssignmentExpression[left.object.name='module'][left.property.name='exports']",
+            "message": "Use named exports instead of module.exports"
+          }
         ]
       }
     },
+    {
+      "files": ["src/client/websocket/handlers/*.js"],
+      "rules": {
+        "no-restricted-syntax": "off"
+      }
+    },
     {
       "files": ["typings/*.ts", "scripts/*.mjs"],
       "parser": "@typescript-eslint/parser",

diff --git a/packages/discord.js/src/errors/DJSError.js b/packages/discord.js/src/errors/DJSError.js
@@ -41,8 +41,6 @@ function message(code, args) {
   return String(...args);
 }
 
-module.exports = {
-  DiscordjsError: makeDiscordjsError(Error),
-  DiscordjsTypeError: makeDiscordjsError(TypeError),
-  DiscordjsRangeError: makeDiscordjsError(RangeError),
-};
+exports.DiscordjsError = makeDiscordjsError(Error);
+exports.DiscordjsTypeError = makeDiscordjsError(TypeError);
+exports.DiscordjsRangeError = makeDiscordjsError(RangeError);
diff --git a/packages/discord.js/src/errors/index.js b/packages/discord.js/src/errors/index.js
@@ -1,5 +1,7 @@
 'use strict';
 
-module.exports = require('./DJSError');
+exports.DiscordjsError = require('./DJSError').DiscordjsError;
+exports.DiscordjsTypeError = require('./DJSError').DiscordjsTypeError;
+exports.DiscordjsRangeError = require('./DJSError').DiscordjsRangeError;
 exports.ErrorCodes = require('./ErrorCodes').ErrorCodes;
 exports.Messages = require('./Messages').Messages;
diff --git a/packages/discord.js/src/util/Channels.js b/packages/discord.js/src/util/Channels.js
@@ -152,10 +152,8 @@ function transformGuildDefaultReaction(defaultReaction) {
   };
 }
 
-module.exports = {
-  createChannel,
-  transformAPIGuildForumTag,
-  transformGuildForumTag,
-  transformAPIGuildDefaultReaction,
-  transformGuildDefaultReaction,
-};
+exports.createChannel = createChannel;
+exports.transformAPIGuildForumTag = transformAPIGuildForumTag;
+exports.transformGuildForumTag = transformGuildForumTag;
+exports.transformAPIGuildDefaultReaction = transformAPIGuildDefaultReaction;
+exports.transformGuildDefaultReaction = transformGuildDefaultReaction;
diff --git a/packages/discord.js/src/util/Components.js b/packages/discord.js/src/util/Components.js
@@ -131,7 +131,8 @@ function createComponentBuilder(data) {
   }
 }
 
-module.exports = { createComponent, createComponentBuilder };
+exports.createComponent = createComponent;
+exports.createComponentBuilder = createComponentBuilder;
 
 const { ActionRow } = require('../structures/ActionRow');
 const { ActionRowBuilder } = require('../structures/ActionRowBuilder');

diff --git a/packages/discord.js/src/util/DataResolver.js b/packages/discord.js/src/util/DataResolver.js
@@ -138,4 +138,9 @@ async function resolveImage(image) {
   return resolveBase64(file.data);
 }
 
-module.exports = { resolveCode, resolveInviteCode, resolveGuildTemplateCode, resolveImage, resolveBase64, resolveFile };
+exports.resolveCode = resolveCode;
+exports.resolveInviteCode = resolveInviteCode;
+exports.resolveGuildTemplateCode = resolveGuildTemplateCode;
+exports.resolveImage = resolveImage;
+exports.resolveBase64 = resolveBase64;
+exports.resolveFile = resolveFile;
diff --git a/packages/discord.js/src/util/Enums.js b/packages/discord.js/src/util/Enums.js
@@ -10,4 +10,4 @@ function createEnum(keys) {
   return obj;
 }
 
-module.exports = { createEnum };
+exports.createEnum = createEnum;
diff --git a/packages/discord.js/src/util/Transformers.js b/packages/discord.js/src/util/Transformers.js
@@ -76,9 +76,7 @@ function _transformGuildScheduledEventRecurrenceRule(recurrenceRule) {
   };
 }
 
-module.exports = {
-  toSnakeCase,
-  _transformAPIAutoModerationAction,
-  _transformAPIMessageInteractionMetadata,
-  _transformGuildScheduledEventRecurrenceRule,
-};
+exports.toSnakeCase = toSnakeCase;
+exports._transformAPIAutoModerationAction = _transformAPIAutoModerationAction;
+exports._transformAPIMessageInteractionMetadata = _transformAPIMessageInteractionMetadata;
+exports._transformGuildScheduledEventRecurrenceRule = _transformGuildScheduledEventRecurrenceRule;
diff --git a/packages/discord.js/src/util/Util.js b/packages/discord.js/src/util/Util.js
@@ -499,26 +499,24 @@ function resolveSKUId(resolvable) {
   return null;
 }
 
-module.exports = {
-  flatten,
-  fetchRecommendedShardCount,
-  parseEmoji,
-  resolvePartialEmoji,
-  makeError,
-  makePlainError,
-  getSortableGroupTypes,
-  moveElementInArray,
-  verifyString,
-  resolveColor,
-  discordSort,
-  setPosition,
-  basename,
-  cleanContent,
-  cleanCodeBlockContent,
-  parseWebhookURL,
-  transformResolved,
-  resolveSKUId,
-};
+exports.flatten = flatten;
+exports.fetchRecommendedShardCount = fetchRecommendedShardCount;
+exports.parseEmoji = parseEmoji;
+exports.resolvePartialEmoji = resolvePartialEmoji;
+exports.makeError = makeError;
+exports.makePlainError = makePlainError;
+exports.getSortableGroupTypes = getSortableGroupTypes;
+exports.moveElementInArray = moveElementInArray;
+exports.verifyString = verifyString;
+exports.resolveColor = resolveColor;
+exports.discordSort = discordSort;
+exports.setPosition = setPosition;
+exports.basename = basename;
+exports.cleanContent = cleanContent;
+exports.cleanCodeBlockContent = cleanCodeBlockContent;
+exports.parseWebhookURL = parseWebhookURL;
+exports.transformResolved = transformResolved;
+exports.resolveSKUId = resolveSKUId;
 
 // Fixes Circular
 const { Attachment } = require('../structures/Attachment');