Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add message.call field #6864

Merged
merged 6 commits into from
May 14, 2024
Merged

add message.call field #6864

merged 6 commits into from
May 14, 2024

Conversation

MCausc78
Copy link
Contributor

available to bots in interactions so why not

@JustinBeckwith JustinBeckwith added the api API issue label May 14, 2024
@JustinBeckwith JustinBeckwith self-assigned this May 14, 2024
@JustinBeckwith
Copy link
Contributor

Thank you for the PR! We have this field marked explicitly as private internally, and not part of the public API. If you ever want to check - we explicitly call out which fields we support in our Open API spec:
https://github.com/discord/discord-api-spec/blob/main/specs/openapi.json

@jhgg
Copy link
Contributor

jhgg commented May 14, 2024

After further deliberation we've decided to mark these fields as public. the initial reasoning behind why they were private was because apps could not actually ever see this field in the course of normal operations (you couldn't call apps, and apps could not participate in GDMs) where this field would be present.

But now with user apps, and it being available in interactions, apps can indeed see this field as part of their normal operations.

As such we're accepting this PR, and as well updating the OpenAPI specs to expose these fields as public.

@jhgg jhgg reopened this May 14, 2024
docs/resources/Channel.md Outdated Show resolved Hide resolved

| Field | Type | Description |
| participants | array of snowflakes | array of [user](#DOCS_RESOURCES_USER/user-object) object ids that participated in the call |
| ended_timestamp | ?ISO8601 timestamp | time when call ended |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not guaranteed to be populated if/when the call ends. it's best effort.

docs/resources/Channel.md Outdated Show resolved Hide resolved
@JustinBeckwith JustinBeckwith merged commit f7393bd into discord:main May 14, 2024
4 checks passed
sebm253 added a commit to disgoorg/disgo that referenced this pull request May 15, 2024
@advaith1
Copy link
Contributor

spec says call is nullable - when is that the case and should that be reflected in the docs?

@MCausc78
Copy link
Contributor Author

spec says call is nullable - when is that the case and should that be reflected in the docs?

https://github.com/discord/discord-api-spec?tab=readme-ov-file#known-issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants