Remove all user account features

[bsian03]

No description provided.

[coolcalcacol]

Ain't GUILD_SYNC a legacy user implementation as well in shard?

[DonovanDMC]

you left some interfaces dangling around (UserProfile/UserSettings) and a bunch of GroupChannel remnants

And some very old bots can technically be in Group Channels iirc, I assume we aren't considering that as a valid enough reason to keep the around though (made a pr, bsian03#21)

[GoldenAngel2]

Client#editGuildIntegration, Client#syncGuildIntegration, Guild#editIntegration, Guild#syncIntegration, GuildIntegration#, GuildIntegration#sync, GuildIntegration#edit can be removed as well, since those can only be used by user accounts.

[bsian03]

I'm in the process of going through all of them now that I'm on my laptop

[DonovanDMC]

Client#getChannel still checks for group channels, which no longer exist

various remnants of Group Channels have been left dotted around

[HeadTriXz]

Client#getChannel still checks for group channels, which no longer exist

various remnants of Group Channels have been left dotted around

Is it worth it to still support group channels though?

[DonovanDMC]

Client#getChannel still checks for group channels, which no longer exist
various remnants of Group Channels have been left dotted around

Is it worth it to still support group channels though?

bsian half removed them and left behind remnants of them
they aren't worth having around

[DonovanDMC]

• setting presence does not work (missing required properties, see previous comment)
• Client#getChannel still checks for group channels, which no longer exist
• various remnants of GroupChannels have been left around (like Client#groupChannels jsdoc, meanwhile neither the property nor class exist)

[DonovanDMC]

More things I've just found, the event definitions for callCreate, callDelete, callRing & callUpdate are still floating around

[gamer0mega]

you may aswell want to remove the hit property from Message, as it is meant for a user-only search feature

[DonovanDMC]

besides the above, LGTM

[DonovanDMC]

I've gone back through some documentation, and now see that GroupChannels are not purely userbot features. Any removals or changes should be undone. Correction: The removals from they gateway are fine, all the other removals should be undone.

#1406 properly implements the official api methods for them.

[HeadTriXz]

I've gone back through some documentation, and now see that GroupChannels are not purely userbot features. Any removals or changes should be undone.

#1406 properly implements the official api methods for them.

Bots can not join group channels anymore though, some bots may still be in one because it was possible in the past. But they do not receive any messages.

[DonovanDMC]

I didn't say they could join them, they can't be received over the gateway sure but they can be retrieved from rest just fine if the bot created it

[bsian03]

Don't think it's worth maintaining/keeping in Eris. The % of bots having continuous access to group channels is miniscule, if anything
Removed gateway references

[bsian03]

bsian03/eris@f4db90e...5168831 for reference

[TTtie]

took a very, very quick glance over this, here's what I've found

[DonovanDMC]

Getting the call property is still possible in some capacity:
discord/discord-api-docs#6864