-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added invite type #6568
Added invite type #6568
Conversation
depends on the bot... you could say that about enough other things as well |
What about moderation bots which filter out certain invite types (disallow guild invites but allow friend invites) only? This is just one out of many use cases for this option. |
This PR looks great to me! @Lulalaby You should clarify that what you say is strictly your opinion, this is data returned from an endpoint which bots most definitely use, it's useful as stated above. |
The documentation proposal is fine as is. Like @quinchs said, you can access this information from a public endpoint. That's a valid enough reason to document it, regardless of whether bot developers will use it or not. |
Yeah you're right @quinchs. Sorry for that. I was half asleep writing that. Personally I agree that it'd be nice to have documented generally, but since it got rejected a few times my hopes are not that high. Sorry again! 🙏💕 |
btw it is already in the OpenAPI specification, it should also be in the API documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition!
Added the invite type based on the OpenAPI specification and api response for guild, group and friend invites