Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type attribute to Invite #9682

Merged
merged 2 commits into from
May 17, 2024
Merged

Add type attribute to Invite #9682

merged 2 commits into from
May 17, 2024

Conversation

Puncher1
Copy link
Contributor

Summary

This PR adds the type attribute to Invite.
As mentioned in the related PR this change got rejected multiple times. But I don't see why. Is there a specific reason it shouldn't be implemented in the library, that I don't know?

Related PR: discord/discord-api-docs#6568

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz Rapptz added the pending PR implements an in-progress or explicitly unreleased Discord feature label Dec 15, 2023
@Rapptz
Copy link
Owner

Rapptz commented Jan 27, 2024

The reason why I believe this wasn't documented is because the various types of invites were all experiments that didn't pan out. Friend invites died, and I don't think group invites are a thing anymore.

@Puncher1
Copy link
Contributor Author

Alright. Let's wait though what the ddevs say to it, unless you already know more than I do about whether something like this will be documented in the future.

@Puncher1
Copy link
Contributor Author

The related PR on Discord's side has been merged.

@Rapptz Rapptz removed the pending PR implements an in-progress or explicitly unreleased Discord feature label May 17, 2024
@Rapptz Rapptz merged commit b9dc85e into Rapptz:master May 17, 2024
8 checks passed
@Puncher1 Puncher1 deleted the invite-type branch May 18, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants