Delete cohttp dependency and split packages#32
Merged
Conversation
Contributor
|
this looks good -- but I thought you'd go further and remove the paf-cohttp entirely (and implement LE based on the http/af stack) :) |
Owner
Author
So, |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jul 26, 2021
CHANGES: - Don't use `disconnect` when the server terminates (@dinosaure, dinosaure/paf-le-chien#28) - The main loop should not leave when it get an error from a client (@dinosaure, dinosaure/paf-le-chien#28) - `Closed` error from TLS layer does not mean that the service is close, wrap such error into a client's `write_error` (@dinosaure, dinosaure/paf-le-chien#28) - Do the compression of the ring-buffer at any call of `read` (@dinosaure, dinosaure/paf-le-chien#29) - Refactore the loop under a common implementation (@dinosaure, dinosaure/paf-le-chien#30) - Add a simple accessor to the peer identity (@dinosaure, dinosaure/paf-le-chien#31) - Cut package between `paf` & `paf-cohttp` (@dinosaure, @hannesm, dinosaure/paf-le-chien#32) - Cut package between `paf` & `paf-le` (@dinosaure, @hannesm, dinosaure/paf-le-chien#33) - Update unikernels with the package layout (@dinosaure, dinosaure/paf-le-chien#34)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @hannesm