The closer (service) should not disconnect the TCP/IP stack which can be re-used by dinosaure · Pull Request #28 · dinosaure/paf-le-chien

dinosaure · 2021-06-21T21:26:23Z

No description provided.

… be re-used

dinosaure · 2021-06-24T10:19:45Z

Few bugs are discovered on this PR:

we should not disconnect the "master" socket at the end of the service, may be we want to re-use it
the accept function should not leave the main-loop when it get an error, it should continue to handle incoming connections
the Closed error returned by the HTTPS service/accept does not systematically means that the given "master" socket is closed but it can refer to the socket with the peer. In that case, we re-map the error to Write Closed to let the accept loop to continue

@dinosaure

CHANGES: - Don't use `disconnect` when the server terminates (@dinosaure, dinosaure/paf-le-chien#28) - The main loop should not leave when it get an error from a client (@dinosaure, dinosaure/paf-le-chien#28) - `Closed` error from TLS layer does not mean that the service is close, wrap such error into a client's `write_error` (@dinosaure, dinosaure/paf-le-chien#28) - Do the compression of the ring-buffer at any call of `read` (@dinosaure, dinosaure/paf-le-chien#29) - Refactore the loop under a common implementation (@dinosaure, dinosaure/paf-le-chien#30) - Add a simple accessor to the peer identity (@dinosaure, dinosaure/paf-le-chien#31) - Cut package between `paf` & `paf-cohttp` (@dinosaure, @hannesm, dinosaure/paf-le-chien#32) - Cut package between `paf` & `paf-le` (@dinosaure, @hannesm, dinosaure/paf-le-chien#33) - Update unikernels with the package layout (@dinosaure, dinosaure/paf-le-chien#34)

dinosaure added 2 commits June 21, 2021 23:23

The closer (service) should not disconnect the TCP/IP stack which can…

7ffc910

… be re-used

Fix the client side when the connection is closed by peer

e6436df

dinosaure mentioned this pull request Jun 24, 2021

Upgrade unipi to paf-le-chien robur-coop/unipi#4

Closed

dinosaure added 2 commits June 24, 2021 11:35

Don't leave when the client expose an error

c771ddc

Don't raise Closed - it means a different error

93aa01f

dinosaure force-pushed the no-disconnect branch from d56c5e6 to 93aa01f Compare June 24, 2021 10:14

dinosaure merged commit 89b6b92 into master Jun 24, 2021

dinosaure mentioned this pull request Jul 26, 2021

[new release] paf, paf-le and paf-cohttp (0.0.4) ocaml/opam-repository#19126

Merged

dinosaure deleted the no-disconnect branch November 16, 2021 14:07

Provide feedback