Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reload pgloader in Makefile #1091

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Do not reload pgloader in Makefile #1091

merged 1 commit into from
Mar 21, 2020

Conversation

phoe
Copy link
Collaborator

@phoe phoe commented Mar 2, 2020

Fixes #1090.

@gjvoosten Please check if this resolves the build issue. Works on my machine, maybe it'll work on yours as well.

@gjvoosten
Copy link

@phoe https://github.com/dimitri/pgloader/tree/bug-1090 does indeed build without errors. 👍

@phoe
Copy link
Collaborator Author

phoe commented Mar 2, 2020

@gjvoosten ❤️

@dimitri Please test and merge freely. I do not yet have a full testing environment for pgloader on my machine, I hope to have it by the end of the week.

@phoe phoe mentioned this pull request Mar 17, 2020
@gjvoosten
Copy link

Hi @dimitri @phoe , can this one be merged? With this fix, PGLoader compiles for me (SBCL 1.5.9) and I can successfully migrate my data (including #1036). Would be nice to have a working master again.

@phoe
Copy link
Collaborator Author

phoe commented Mar 19, 2020

@gjvoosten I have no personal problem with that, but I never got the official blessing from @dimitri to merge PRs on my own. So, even though I technically have merge rights to the repository, I need to wait for Dimitri's word in order to modify the official master branch of pgloader.

@gjvoosten
Copy link

gjvoosten commented Mar 19, 2020

@phoe Understood. For reference: just compiled PGLoader with SBCL 2.0.2, and that also works (data migration from mssql to postgresql went fine). So this should close some more issues (like #1087, #1005, #1000).

@dimitri dimitri merged commit 94d0612 into master Mar 21, 2020
@dimitri
Copy link
Owner

dimitri commented Mar 21, 2020

Thanks @phoe !

@dimitri dimitri deleted the bug-1090 branch March 21, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master currently broken on package issues
3 participants