Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgloader 3.6.1 compiling error with sbcl stable 2.0.1 #1087

Closed
4 tasks done
tigerfoot opened this issue Feb 22, 2020 · 11 comments
Closed
4 tasks done

pgloader 3.6.1 compiling error with sbcl stable 2.0.1 #1087

tigerfoot opened this issue Feb 22, 2020 · 11 comments

Comments

@tigerfoot
Copy link

  • pgloader --version

3.6.1 (bundle source)
```

  • did you test a fresh compile from the source tree?
    For our openSUSE Tumbleweed rolling release, every package is build every time on a new and fresh system (ala travis)

  • did you search for other similar issues?
    Have search sbcl 2 issues here but not found

  • how can I reproduce the bug?
    Try to compile pgloader with the last stable sbcl which is now at version 2.0.1

You can have a look at the whole build (and failure) at the following
Build log on obs

warnings about depreciation, that one day will become error, and we need to fix ;-)

[   58s] WARNING:
[   58s]    Lisp compilation had style-warnings while
[   58s]    compiling #<CL-SOURCE-FILE "buildapp" "buildapp">
[   58s] WARNING:
[   58s]    Reference to deprecated function (SB-DEBUG:BACKTRACE-AS-LIST) from COMMAND-LINE-DEBUGGER

fatal error

[   58s] ;; loading system "buildapp"
[   63s] bin/buildapp      --logfile /tmp/pgloader-bundle-build.log     \
[   63s]                          --require sb-posix --require sb-bsd-sockets --require sb-rotate-byte                             \
[   63s]                          --sbcl sbcl                                 \
[   63s]                          --asdf-tree .                                \
[   63s]                          --load-system cffi                           \
[   63s]                          --load-system cl+ssl                         \
[   63s]                          --load-system mssql                          \
[   63s]                          --load local-projects/pgloader-3.6.1/src/hooks.lisp              \
[   63s]                          --load-system pgloader                    \
[   63s]                          --eval '(setf pgloader.params::*version-string* "3.6.1")' \
[   63s]                          --entry pgloader:main                        \
[   63s]                          --dynamic-space-size 4096              \
[   63s]                          --compress-core                         \
[   63s]                          --output bin/pgloader.tmp
[   63s] ;; loading system "cffi"
[   72s] Fatal SIMPLE-ERROR:
[   72s]   Compilation failed: :LINKAGE-TABLE is no longer present in *FEATURES* in /home/abuild/rpmbuild/BUILD/pgloader-bundle-3.6.1/software/cffi_0.20.0/src/cffi-sbcl.lisp
[   72s] make: *** [Makefile:47: bin/pgloader] Error 1
[   72s] error: Bad exit status from /var/tmp/rpm-tmp.Qn6Vgx (%build)
[   72s] 

I've no real knowledge about lisp so any pointer or patches that can be applied would be great.
I guess this type of fix + pg12 support will drive us to a new version?

@tigerfoot
Copy link
Author

Any news ? Unfortunately, if I don't fix the build compile error on Tumbleweed soon, the package will have to be removed, I would be really worried about that.

@tigerfoot
Copy link
Author

Like for example release a new version with cffi version 0.21
https://github.com/cffi/cffi/releases/tag/v0.21.0
SBCL no longer pushes :linkage-table to *features*

@phoe
Copy link
Collaborator

phoe commented Mar 3, 2020

Not related to pgloader itself.

This is an error related to SBCL removing the *LINKAGE-TABLE* feature in its newest versions.

Please update CFFI to a new version, preferably one that includes the commit cffi/cffi@375872a that fixes this issue.

@tigerfoot
Copy link
Author

cffi is contained in the pgloader bundle available as release, so still a bit related to pgloader ;-)
That's why (plus all the issues closed since last 3.6.1) I've feel that the time to a new release is coming.

@phoe
Copy link
Collaborator

phoe commented Mar 3, 2020

A workaround would be to use an older SBCL version, e.g. 2.0.0 or earlier.

@tigerfoot
Copy link
Author

Unfortunately I don't know a packager able to downgrade a software version on a mainstream distribution, sbcl maintainer at openSUSE decide that 2.0.1 is the latest stable (and upstream too), so do I accept and live with ;-)
I've just make a test with cffi 0.21.0 replaced in the bundle and now I get pgloader building again, so a temporary fix.

@phoe
Copy link
Collaborator

phoe commented Mar 3, 2020

I'll track the new release at #1092.

@tigerfoot
Copy link
Author

Thanks I'm closing this one so.

@phoe
Copy link
Collaborator

phoe commented Mar 14, 2020

I'll allow myself to reopen, since we only have a workaround and not a proper fix.

@phoe
Copy link
Collaborator

phoe commented Mar 22, 2020

Fixed in #1092. Please use the freshly released version 3.6.2 that is buildable with the newer SBCL versions.

@phoe phoe closed this as completed Mar 22, 2020
@tigerfoot
Copy link
Author

Super, big thanks for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants