Support for CRA 5 #332
Merged
Support for CRA 5 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR @bkrausz, very appreciated! I have a very busy week, I'll get back at you this week-end :) |
|
Since it's not backward compatible and CRA5 is in alpha I prefer not merging anything which is not backward compatible into master. I created a support-cra5 branch. Could you please update your PR to merge into that branch instead? Thank you, Patrick |
|
Can we create an alpha release for this? I need to utilize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #313
Doesn't update the peer dependency, but this does allow craco to work with react-scripts 5. I have not tested every feature so it's possible there's some config-munging that expects a now-changed format.
Right now this isn't backwards compatible with react-scripts 4, as I needed to use Jest 27's async transformations (it seems globals are now getting cleared). I can look into adding conditional support based on the Jest version, but putting this up now in case others want to play with it.