Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes peer dependency issue and updates README #367

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

ImanMh
Copy link

@ImanMh ImanMh commented Jan 1, 2022

Supporting Craco for CRA-5. This will fix the issue of "peer react-scripts@"^4.0.0" from @craco/[email protected]".

@patricklafrance
Copy link
Contributor

Hi @ImanMh

Thanks for the PR.

Unfortunately, before upgrading the dependency to react-script 5 the issues between CRA 5 and CRACO must be resolved.

If you want to to contribute, have a look at these: #353 #313

Thank you

@ImanMh
Copy link
Author

ImanMh commented Jan 2, 2022

Hi @patricklafrance ,

I thought the order does not matter since it's on branch "support-cra5". You've merged !332 and I saw that everything seems to be working except that you can't install CRACO when you have CRA@5 installed. Can you also mention what things are not working at this moment?

@patricklafrance
Copy link
Contributor

Oh sorry I haven’t notice your PR is for the support branch.

@patricklafrance patricklafrance merged commit 8db54e0 into dilanx:support-cra5 Jan 2, 2022
@ImanMh
Copy link
Author

ImanMh commented Jan 2, 2022

No problems bro, I guessed you might not see that. Anyways It seems like everything is working now. That would be great if you can also publish an alpha version so we use it in real projects and fixing the issues as we encounter them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants