Edge-weights #3: minimum spanning trees #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtorpey
added
new-feature
james-d-mitchell
requested changes
May 24, 2024
Member
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
Quick comments that occur to me on quick inspection:
- there seem to be some white space only changes in these changes, might be easier to review if those were reverted or separated into a separate pr
- there's an xml entity that should be included in the doc for attributes and properties that says something to the effect of "for mutable digraphs this is recomputed every time the function is called"
- I noticed that there's a union find implementation in the pr, but this already exists in the data structures package which I think we already require, be better to use that than roll our own again.
Otherwise looks good! On my phone so excuse the brevity!
mtorpey
force-pushed
the
edge-weights-3-minimum-spanning-tree
branch
from
39ff2a3 to
fc19425
Compare
Collaborator
Author
|
@james-d-mitchell: Thanks for the comments. Changed as you suggested. Failing Codespell due to an unrelated "satsifies" elsewhere in the doc. Not sure why that's only appearing here, but I don't think it's related to this PR. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.