Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor start scripts, Fixes #7 #8 #9 #10 #11

Merged
merged 44 commits into from
Apr 14, 2021

Conversation

ronilaukkarinen
Copy link
Member

@ronilaukkarinen ronilaukkarinen commented Apr 12, 2021

Project start scripts have been refactored completely.

Changes:

  • Deprecated docker and vagrant - they are horribly outdated and we can't support them no longer. dudestack-docker has been retired.
  • Add working WSL support (documentation), linked also to windows-lemp-setup
  • Modularize bash scripts, add files as partials. From now on we need to edit files under bin/tasks and no need to touch main files macos.sh and wsl.sh
  • Beautiful formatting and instructions to start script
  • Prevent running directly with bash or sh to prevent possible issues with them
  • Variable all the things - no need to search and replace stuff
  • Fix typos
  • Fix WP-CLI commands, there were couple of issues with it
  • Fix cleanups - we had wp-cli.yml credentials left saved to project - oops!
  • Add some checks (is git found, are certs created, is mkcert found etc.)
  • Add extra notifications that these scripts need dudestack and dev servers to work
  • Move everything to .env_createproject in $HOME. No more setup.sh or complicated generate scripts, everything should work directly from dudestack repo WITH updates in the future

@ronilaukkarinen ronilaukkarinen changed the title Refactor start scripts Refactor start scripts, Fixes #7 #8 #9 #10 Apr 13, 2021
@ronilaukkarinen
Copy link
Member Author

Made it even better, now it recgnized where you run the script and can point the imports even they are not in correct location. Btw this PR Fixes issues #7 #8 #9 #10.

@ronilaukkarinen
Copy link
Member Author

Tested by me just now on macOS:

Screen-Shot-2021-04-13-17-45-38 19

Screen-Shot-2021-04-13-17-45-51 72

Tested by @divn just now on WSL (Ubuntu 18.04 built on windows-lemp).

@timiwahalahti
Copy link
Contributor

Looks good! Can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants