Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor start scripts #89

Merged
merged 13 commits into from
Apr 14, 2021
Merged

Refactor start scripts #89

merged 13 commits into from
Apr 14, 2021

Conversation

ronilaukkarinen
Copy link
Member

Project start scripts have been refactored completely same manner than in this PR.

Changes:

  • Add working WSL support (documentation), linked also to windows-lemp-setup
  • Modularize bash scripts, add files as partials. From now on we need to edit files under bin/tasks. Only couple of files are different, for example sed commands for debian and macOS vary, that's why
  • Beautiful formatting and instructions for the start script (header.sh, footer.sh)
  • Prevent running directly with bash or sh to prevent possible issues with them
  • Variable all the things - no need to search and replace stuff
  • Fix typos
  • Add checks for missing packages (WSL mainly)
  • Add extra notifications that these scripts need Air-light and dev servers to work

@ronilaukkarinen
Copy link
Member Author

macOS version tested successfully just now.

Copy link
Member Author

@ronilaukkarinen ronilaukkarinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a mistake. Will revert in the morning.

@ronilaukkarinen ronilaukkarinen merged commit 5135af6 into master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant