Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort definitions of SMV models to reduce recursion depth in typecheck #234

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Sort definitions of SMV models to reduce recursion depth in typecheck #234

wants to merge 3 commits into from

Conversation

mgudemann
Copy link
Contributor

This fixes #17 (superseeding #26 as EBMC code has changed)

@kroening
Copy link
Member

kroening commented Dec 3, 2023

How about using a std::stack?

@mgudemann
Copy link
Contributor Author

For the topological sort? Sure, but this is implemented in cbmc/src/util/graph.h so it would require a change to CBMC.

@kroening
Copy link
Member

kroening commented Dec 3, 2023

For the topological sort? Sure, but this is implemented in cbmc/src/util/graph.h so it would require a change to CBMC.

No, to replace the recursion. Then you don't need the topological sort anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

segfault on typecheck
2 participants
@mgudemann @kroening