Repository navigation
chore(skills): regenerate cli-backup-sync SKILL.md to match catalog - #8657
Merged
diegosouzapw merged 2 commits intoJul 27, 2026
Merged
diegosouzapw merged 2 commits into
diegosouzapw merged 2 commits into
Conversation
check:agent-skills-sync was failing on release/v3.8.49 tip because the generated SKILL.md still documented backup-status flags the catalog no longer exposes. Re-run generate-agent-skills --apply (9-line delete only).
4 tasks
Contributor
Author
|
Root-cause tracking (parser + process, not this regenerate-only PR): #8658 |
MumuTW
added a commit
to MumuTW/OmniRoute
that referenced
this pull request
Jul 26, 2026
Same tip fix as diegosouzapw#8657 so Merge integrity is green without waiting for that PR to land. Regenerated via generate-agent-skills --apply.
MumuTW
added a commit
to MumuTW/OmniRoute
that referenced
this pull request
Jul 26, 2026
Same tip fix as diegosouzapw#8657 so Merge integrity is green without waiting for that PR to land. Regenerated via generate-agent-skills --apply.
MumuTW
added a commit
to MumuTW/OmniRoute
that referenced
this pull request
Jul 26, 2026
Same tip fix as diegosouzapw#8657 so Merge integrity is green without waiting for that PR to land. Regenerated via generate-agent-skills --apply.
MumuTW
added a commit
to MumuTW/OmniRoute
that referenced
this pull request
Jul 26, 2026
Same tip fix as diegosouzapw#8657 so Merge integrity is green without waiting for that PR to land. Regenerated via generate-agent-skills --apply.
MumuTW
added a commit
to MumuTW/OmniRoute
that referenced
this pull request
Jul 26, 2026
Same tip fix as diegosouzapw#8657 so Merge integrity is green without waiting for that PR to land. Regenerated via generate-agent-skills --apply.
MumuTW
added a commit
to MumuTW/OmniRoute
that referenced
this pull request
Jul 26, 2026
Same tip fix as diegosouzapw#8657 so Merge integrity is green without waiting for that PR to land. Regenerated via generate-agent-skills --apply.
MumuTW
added a commit
to MumuTW/OmniRoute
that referenced
this pull request
Jul 26, 2026
Regenerate file-size-baseline.json with --update after the merge train. Includes skills SKILL.md sync (diegosouzapw#8657 equivalent) so Merge integrity is green.
This was referenced Jul 26, 2026
Owner
|
Hi @MumuTW — the SKILL regen is welcome. The catalog-vs-SKILL drift on Approved as |
MumuTW
added a commit
to MumuTW/OmniRoute
that referenced
this pull request
Jul 27, 2026
Regenerate file-size-baseline.json with --update after the merge train. Includes skills SKILL.md sync (diegosouzapw#8657 equivalent) so Merge integrity is green.
diegosouzapw
pushed a commit
that referenced
this pull request
Jul 28, 2026
…nly (#8619) * test(quality): fail loudly when a source-scanning guard is negative-only A negative guard — assert.doesNotMatch(src, /x/) or src.includes(x) === false — passes against an empty string. Once the code it guards is extracted into another file the parent no longer contains the string, so the assertion keeps passing while protecting nothing. The regression coverage is deleted with no test turning red, which is exactly the failure mode the god-file decomposition campaign (#8617) is about to trigger 90-odd times. Adds tests/unit/source-scanner-guards.test.ts: a hard gate (no baseline, no allowlist) requiring every test variable bound to project source to carry at least one positive anchor. Classification runs on logical statements with strings, regexes and comments blanked out, so a guard wrapped across lines cannot slip past — that folding is what exposed 3 of the 7 violations. Fixes all 7 violations across 6 files with one stable top-level export anchor each. Two were security scope guards held only by multi-line negative assertions: the SSRF guards on /api/sync/initialize (#323) and the proxy-bypass guards on chatHelpers.ts and chatCore.ts (#3226) — the latter anchored on handleChatCore precisely because that file is a decomposition target. Adds tests/_helpers/readSrc.ts, a repo-root-relative reader that throws on a missing or empty file instead of returning "". Refs #8617 * docs(changelog): number the fragment for #8619 * chore(skills): sync cli-backup-sync SKILL.md with catalog Same tip fix as #8657 so Merge integrity is green without waiting for that PR to land. Regenerated via generate-agent-skills --apply.
Merged
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
…iegosouzapw#8657) * chore(skills): regenerate cli-backup-sync SKILL.md to match catalog check:agent-skills-sync was failing on release/v3.8.49 tip because the generated SKILL.md still documented backup-status flags the catalog no longer exposes. Re-run generate-agent-skills --apply (9-line delete only). * docs(changelog): add fragment for diegosouzapw#8657 agent-skills sync
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…iegosouzapw#8657) * chore(skills): regenerate cli-backup-sync SKILL.md to match catalog check:agent-skills-sync was failing on release/v3.8.49 tip because the generated SKILL.md still documented backup-status flags the catalog no longer exposes. Re-run generate-agent-skills --apply (9-line delete only). * docs(changelog): add fragment for diegosouzapw#8657 agent-skills sync
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…nly (diegosouzapw#8619) * test(quality): fail loudly when a source-scanning guard is negative-only A negative guard — assert.doesNotMatch(src, /x/) or src.includes(x) === false — passes against an empty string. Once the code it guards is extracted into another file the parent no longer contains the string, so the assertion keeps passing while protecting nothing. The regression coverage is deleted with no test turning red, which is exactly the failure mode the god-file decomposition campaign (diegosouzapw#8617) is about to trigger 90-odd times. Adds tests/unit/source-scanner-guards.test.ts: a hard gate (no baseline, no allowlist) requiring every test variable bound to project source to carry at least one positive anchor. Classification runs on logical statements with strings, regexes and comments blanked out, so a guard wrapped across lines cannot slip past — that folding is what exposed 3 of the 7 violations. Fixes all 7 violations across 6 files with one stable top-level export anchor each. Two were security scope guards held only by multi-line negative assertions: the SSRF guards on /api/sync/initialize (diegosouzapw#323) and the proxy-bypass guards on chatHelpers.ts and chatCore.ts (diegosouzapw#3226) — the latter anchored on handleChatCore precisely because that file is a decomposition target. Adds tests/_helpers/readSrc.ts, a repo-root-relative reader that throws on a missing or empty file instead of returning "". Refs diegosouzapw#8617 * docs(changelog): number the fragment for diegosouzapw#8619 * chore(skills): sync cli-backup-sync SKILL.md with catalog Same tip fix as diegosouzapw#8657 so Merge integrity is green without waiting for that PR to land. Regenerated via generate-agent-skills --apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge integrity (changelog + generated skills)has been failing on every PR→release/v3.8.49with:Tip's
skills/cli-backup-sync/SKILL.mdwas stale vs the catalog: it still listedbackup statusflags (--name,--cloud,--encrypt, …) the generator no longer emits.Fix
Diff is −9 lines in
skills/cli-backup-sync/SKILL.mdonly. After apply, dry-run isGenerated: 0 · Unchanged: 45.Why this matters
Unblocks Merge integrity for the whole queue (including #8424, #8580, #8589, #8604, #8605, #8619).
Test plan
npm run check:agent-skills-syncgreen on this branch