Conversation
|
Aligned with the diagnosis on #8405. Local check: |
|
Thanks for the fast turnaround on this, @MumuTW — the diagnosis and fix approach (export the const from Timing caught this one: the identical two-line fix was independently merged into We tried a real merge of this branch against the current tip to double check, and it does produce a duplicate Your |
30ab319 to
febfcbc
Compare
|
Took the second option — rebased onto the current Good call on #8390 — I confirmed the tip already carries the fix ( Verified it is a real guard, not a vacuous assertion:
So it goes red exactly on the state #8405 reported and green on the fixed state. The second test also pins the import in |
|
Heads-up on the red The failing step is I checked out Opened #8524 with the baseline bump + justification entry, following the |
… import Rebased onto release/v3.8.49 and reduced to the test file only — the production fix landed in diegosouzapw#8390. Asserts chatPredicates exports the Set with the documented statuses and that chat.ts imports the symbol cleanly.
febfcbc to
2fcd4ad
Compare
…gression guard
Same tip fix as diegosouzapw#8657 so Merge integrity is green without waiting for that PR to land. Regenerated via generate-agent-skills --apply.
Closing — the guard this PR adds is already enforced on the release tipThanks for this one. Verified against
The dedicated regression file from this PR does not exist on the tip, but the same declaration is already asserted by Closing as already-covered. If you spot a gap the current coverage misses, please reopen with the specific case — the concern behind this PR was a real one. |
Rebased onto tip (
release/v3.8.49). Reduced to regression-test-only as the production fix landed in #8390.Adds unit test
tests/unit/breaker-failure-statuses-8405.test.tsto assert thatchatPredicates.tsexportsPROVIDER_BREAKER_FAILURE_STATUSESas aSetwith the expected failure statuses[408, 500, 502, 503, 504]and thatchat.tsexplicitly imports it without ReferenceError.