Repository navigation
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Thanks for the extraction — the header/identity alignment (buildKiroClientHeaders, machine-id-based User-Agent), region/runtime routing split (legacy vs native runtime.{region}.kiro.dev), and OAuth auto-import social-login handling all look solid and are well covered (140/140 targeted tests + the translate-path golden pass locally, lint clean). One thing needs to be resolved before merge: this PR reinstates Could you either:
Everything else here reads as a genuine improvement and I'd be happy to see it land once that one point is settled. |
6e4d50d to
6cbfb0d
Compare
|
Agreed — I do not have fresh live evidence for those four ids, so I took option 2. The static registry and catalog guards are back to the #6170-confirmed set. The discovery, header, and runtime work stays in place, and the new discovery mocks now use Sonnet 4.5 / Haiku 4.5 instead of implying support for the unverified models. The amended commit is 6cbfb0d. The core typecheck, targeted ESLint, and 141 focused Kiro tests pass. |
1d330bd to
3c1c799
Compare
3c1c799 to
e9c11b2
Compare
|
Thanks, @backryun — closing this one after a careful look. 🙏 It reduces |
I've reviewed it. I'll cherry-pick only the necessary parts and rewrite the PR to make it cleaner. |
Summary
Extracted from #6958 as the Kiro only change set.
Why
The Kiro integration had drifted from the native IDE API contract across identity, region selection, discovery, and reasoning transport.
Impact
This changes Kiro provider behavior only and can merge independently.
Validation