Repository navigation
fix(cli): ship head-response-guard.cjs in the standalone bundle - #6908
Merged
Merged
Conversation
server-ws.mjs imports ./head-response-guard.cjs, but assembleStandalone had no EXTRA_MODULE_ENTRIES entry for it, so every build:release bundle crashed at boot with ERR_MODULE_NOT_FOUND (found deploying d1d75fd to the VPS on 2026-07-11). Adds the missing entry plus a regression test that derives the required sidecar list from server-ws.mjs's own relative imports, guarding the whole class of missing-sidecar bugs.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
7 tasks done
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
…osouzapw#6908) * fix(cli): ship head-response-guard.cjs in the standalone bundle server-ws.mjs imports ./head-response-guard.cjs, but assembleStandalone had no EXTRA_MODULE_ENTRIES entry for it, so every build:release bundle crashed at boot with ERR_MODULE_NOT_FOUND (found deploying 3025ac9 to the VPS on 2026-07-11). Adds the missing entry plus a regression test that derives the required sidecar list from server-ws.mjs's own relative imports, guarding the whole class of missing-sidecar bugs. * docs(changelog): fragment for diegosouzapw#6908
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…osouzapw#6908) * fix(cli): ship head-response-guard.cjs in the standalone bundle server-ws.mjs imports ./head-response-guard.cjs, but assembleStandalone had no EXTRA_MODULE_ENTRIES entry for it, so every build:release bundle crashed at boot with ERR_MODULE_NOT_FOUND (found deploying 23435b0 to the VPS on 2026-07-11). Adds the missing entry plus a regression test that derives the required sidecar list from server-ws.mjs's own relative imports, guarding the whole class of missing-sidecar bugs. * docs(changelog): fragment for diegosouzapw#6908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dist/server-ws.mjs(assembled fromscripts/dev/standalone-server-ws.mjs) imports./head-response-guard.cjs, butscripts/build/assembleStandalone.mjshas noEXTRA_MODULE_ENTRIESentry for it. Result: everybuild:releasebundle crashes at boot with:Found live while deploying
d1d75fdbf(v3.8.47) to the VPS on 2026-07-11 — the server crash-looped until the file was copied manually.Fix
head-response-guard.cjsentry toEXTRA_MODULE_ENTRIES(next to its siblinghttp-method-guard.cjs) + header table row.Test (TDD)
New regression test in
tests/unit/build/assemble-standalone.test.tsthat derives the required sidecar list fromstandalone-server-ws.mjs's own relative imports and asserts each one is shipped bysyncStandaloneExtraModules— failing first onhead-response-guard.cjs, passing after the fix. This guards the whole class (any future relative import added to server-ws without a matching bundle entry fails the suite).Validation
node --import tsx/esm --test tests/unit/build/assemble-standalone.test.ts→ 4/4 pass (was 3/4 + 1 fail before the fix)health: healthy, version 3.8.47