Repository navigation
Conversation
diegosouzapw#6608 added `import headResponseGuard from './head-response-guard.cjs'` to scripts/dev/standalone-server-ws.mjs but never added the copy entry to assembleStandalone.mjs. The standalone Docker image crashed at boot with ERR_MODULE_NOT_FOUND /app/head-response-guard.cjs. The new test derives ALL relative imports of standalone-server-ws.mjs and asserts each has a copy entry, so a future sibling module cannot silently break the container again.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Thanks for catching this — same root cause and same fix as #6908, which was opened independently and landed a slightly more thorough regression test (it exercises the real copy function against a temp directory rather than string-matching the source). Since both patches touch the identical EXTRA_MODULE_ENTRIES lines and conflict with each other, I'm merging #6908 and closing this one as a duplicate rather than asking you to rebase around it. Appreciate the report and the Docker-side repro — that's genuinely useful confirmation the fix also resolves the container boot crash, not just the CLI dist. |
|
Thanks for catching this — same root cause and same fix as #6908, which landed a slightly more thorough regression test (exercises the real copy function against a temp dir rather than string-matching the source). Both patches touch the identical EXTRA_MODULE_ENTRIES lines and would conflict, so I merged #6908 and am closing this as a duplicate. Appreciate the report and the Docker-side repro. |
Problem
The standalone Docker image (targets
runner-base/runner-web/runner-cli) crashes at boot:#6608 ("close HEAD requests immediately instead of hanging", #6400) added
to
scripts/dev/standalone-server-ws.mjs, but did not add a copy entry toscripts/build/assembleStandalone.mjs. That script copies eachserver-ws.mjssibling dependency into the standalone bundle individually (peer-stamp.mjs, http-method-guard.cjs, responses-ws-proxy.mjs, webdav-handler.mjs, tls-options.mjs) — so the new module never lands in the image and the container restart-loops.Fix
head-response-guard.cjstoassembleStandalone.mjs.tests/unit/standalone-server-ws-deps-copied.test.tsextracts all relative imports ofstandalone-server-ws.mjsand asserts each one has a copy entry — so any future sibling module added to server-ws without a copy entry fails CI instead of breaking the container at boot.Validation (TDD, Hard Rule #18)
assembleStandalone.mjs must copy these server-ws.mjs dependencies: head-response-guard.cjs; passes after the fix.--target runner-cli) from this branch and verified/app/head-response-guard.cjsand/app/server-ws.mjsare present; the previousERR_MODULE_NOT_FOUNDboot crash is gone.