test: split responses local shell coverage - #6031
Closed
KooshaPari wants to merge 2 commits into
Closed
KooshaPari wants to merge 2 commits into
KooshaPari wants to merge 2 commits into
Conversation
The internal handleResponse() in src/shared/utils/api.ts still called response.json() raw, so a non-JSON error body (e.g. a 502 text/plain response) crashed with a SyntaxError instead of surfacing a clean error to callers of get/post/put/del. Reuse the already-present parseResponseBody/getErrorMessage helpers (already used by the OAuth modal call sites) so the shared client degrades gracefully on any non-JSON non-OK response. Co-authored-by: Delcado <Delcado@gmx.net> Inspired-by: decolua/9router#1340
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
4 tasks done
diegosouzapw
force-pushed
the
fix/port-pr-1340-oauth-nonjson-guard
branch
from
July 3, 2026 03:18
4d20be8 to
438ea48
Compare
diegosouzapw
deleted the branch
diegosouzapw:fix/port-pr-1340-oauth-nonjson-guard
July 3, 2026 04:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI rescue for #5973.
This keeps the non-JSON API guard implementation unchanged and only splits the local_shell translator coverage out of the frozen translator request test file.
Evidence from #5973 CI:
Local validation on commit 6370b56:
Direct fast-forward push to the upstream source branch was attempted after the merge-base ancestor check passed, but upstream write access failed with: fatal: Could not read from remote repository.