Conversation
diegosouzapw
added a commit
to diegosouzapw/OmniRoute
that referenced
this pull request
Jul 3, 2026
The internal handleResponse() in src/shared/utils/api.ts still called response.json() raw, so a non-JSON error body (e.g. a 502 text/plain response) crashed with a SyntaxError instead of surfacing a clean error to callers of get/post/put/del. Reuse the already-present parseResponseBody/getErrorMessage helpers (already used by the OAuth modal call sites) so the shared client degrades gracefully on any non-JSON non-OK response. Co-authored-by: Delcado <Delcado@gmx.net> Inspired-by: decolua/9router#1340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle non-JSON OAuth and API error responses
Fixes #1318.
Summary
Unexpected token ...crashes when OAuth/provider endpoints return plain-text or HTML error responses.Validation
Notes
This PR is intentionally scoped to shared response parsing and OAuth modal error handling.