test: align two tests left red by merged PRs (#4335 db-rules count + #4271 arena metadata) - #4346
Merged
Merged
Conversation
#4335 added apiKeyColumnFallbacks + apiKeyUsageLimitFields to INTENTIONALLY_INTERNAL (both db-internal, consumed only by db/apiKeys.ts) but did not update the parity test in check-db-rules-classification.test.ts, which still expected exactly 26 audited modules — leaving it red on release/v3.8.30 (28 != 26). Add the two modules to the expected list and bump the count to 28. Test-only alignment; no production change.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…4271) #4271/#4331 updated webSessionCredentials.ts for lmarena's split auth cookie — new placeholder text and storageKeys arena-auth-prod-v1.0/.1 — but did not update web-session-credentials.test.ts, which still asserted the old placeholder + 3-key storageKeys. Align the expected metadata to the merged source; test-only, no prod change.
diegosouzapw
changed the title
Merged
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…les count + diegosouzapw#4271 arena metadata) (diegosouzapw#4346) * test(db-rules): align audited-module count to 28 (apiKey db helpers) diegosouzapw#4335 added apiKeyColumnFallbacks + apiKeyUsageLimitFields to INTENTIONALLY_INTERNAL (both db-internal, consumed only by db/apiKeys.ts) but did not update the parity test in check-db-rules-classification.test.ts, which still expected exactly 26 audited modules — leaving it red on release/v3.8.30 (28 != 26). Add the two modules to the expected list and bump the count to 28. Test-only alignment; no production change. * test(web-session): align lmarena metadata to the split-cookie source (diegosouzapw#4271) diegosouzapw#4271/diegosouzapw#4331 updated webSessionCredentials.ts for lmarena's split auth cookie — new placeholder text and storageKeys arena-auth-prod-v1.0/.1 — but did not update web-session-credentials.test.ts, which still asserted the old placeholder + 3-key storageKeys. Align the expected metadata to the merged source; test-only, no prod change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test-only alignments for unit tests left red on release/v3.8.30 by merged PRs that changed source/config without updating the matching assertion. Both only surface under the full unit suite (
__RUN_ALL__), so the narrow Fast-QG of the merging PRs didn't catch them.1. db-rules audited-module count (from #4335)
#4335 added
apiKeyColumnFallbacks+apiKeyUsageLimitFieldstoINTENTIONALLY_INTERNAL(bothdb-internal, imported only bydb/apiKeys.ts) but didn't updatecheck-db-rules-classification.test.ts, which hard-codes the audited list and asserts exactly 26. Now 28 → red. Added the two modules toexpectedand bumped the count to 28.2. lmarena split-cookie metadata (from #4271)
#4271/#4331 updated
webSessionCredentials.tsfor lmarena's split auth cookie (new placeholder +arena-auth-prod-v1.0/.1storageKeys) but didn't updateweb-session-credentials.test.ts, which still asserted the old placeholder + 3-key array. Aligned the expected metadata to the merged source.Validation (Hard Rule #18)
Both were red → green:
check-db-rules-classification.test.ts: 5/5.web-session-credentials.test.ts: 4/4.Test-only; no production code change.