fix(quality): restore release/v3.8.30 green — 3 latent reds from concurrent merges - #4335
Merged
Merged
Conversation
…10 models) The provider-model sweep (#4324) added qwen3.7-plus, qwen3-coder-plus, qwen3-coder-next and glm-4.7 to the bailian-coding-plan registry entry but left the static fallback mirror in staticModels.ts at the older six, so the static↔registry parity test (bailian-coding-plan-provider.test.ts) went red on release/v3.8.30 whenever TIA selected it. Restore the mirror to all ten models in registry order and align the two legacy count/ID assertions.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
PR #4326 (ComboContext god-file split) added tests/unit/combo/combo-context.test.ts but the unit-runner brace glob had no 'combo' entry, so its 4 tests were orphaned — check:test-discovery flagged a NEW orphan, a second latent red on release/v3.8.30. Add 'combo' to the glob across all lock-step collectors: the 7 package.json test scripts, build-test-impact-map.mjs, check-test-discovery.mjs and the 4 ci.yml run lines. Folded here (rather than a separate PR) because the two release reds are interdependent for Fast-QG: a package.json change triggers the full suite, so a combo-only PR would still trip the bailian red and vice-versa — fixing both in one PR is the only way to land a genuinely green Fast-QG.
diegosouzapw
changed the title
… db-internal The api-key usage-limits feature (migration 101) split two helper modules out of src/lib/db/apiKeys.ts — apiKeyColumnFallbacks.ts and apiKeyUsageLimitFields.ts — but did not register them with check:db-rules, so both were flagged as new db/ modules not re-exported by localDb.ts (Hard Rule #2), a third latent red on release/v3.8.30. Both are imported only by db/apiKeys.ts (within src/lib/db/), so they are db-internal: add them to INTENTIONALLY_INTERNAL with that classification (mirrors healthCheck / stateReset) rather than re-exporting internal helpers onto the public localDb surface.
diegosouzapw
changed the title
diegosouzapw
added a commit
that referenced
this pull request
Jun 20, 2026
…4271 arena metadata) (#4346) * test(db-rules): align audited-module count to 28 (apiKey db helpers) #4335 added apiKeyColumnFallbacks + apiKeyUsageLimitFields to INTENTIONALLY_INTERNAL (both db-internal, consumed only by db/apiKeys.ts) but did not update the parity test in check-db-rules-classification.test.ts, which still expected exactly 26 audited modules — leaving it red on release/v3.8.30 (28 != 26). Add the two modules to the expected list and bump the count to 28. Test-only alignment; no production change. * test(web-session): align lmarena metadata to the split-cookie source (#4271) #4271/#4331 updated webSessionCredentials.ts for lmarena's split auth cookie — new placeholder text and storageKeys arena-auth-prod-v1.0/.1 — but did not update web-session-credentials.test.ts, which still asserted the old placeholder + 3-key storageKeys. Align the expected metadata to the merged source; test-only, no prod change.
Merged
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…urrent merges (diegosouzapw#4335) * fix(providers): bailian-coding-plan static catalog matches registry (10 models) The provider-model sweep (diegosouzapw#4324) added qwen3.7-plus, qwen3-coder-plus, qwen3-coder-next and glm-4.7 to the bailian-coding-plan registry entry but left the static fallback mirror in staticModels.ts at the older six, so the static↔registry parity test (bailian-coding-plan-provider.test.ts) went red on release/v3.8.30 whenever TIA selected it. Restore the mirror to all ten models in registry order and align the two legacy count/ID assertions. * chore(test): collect tests/unit/combo/ in the unit runner glob PR diegosouzapw#4326 (ComboContext god-file split) added tests/unit/combo/combo-context.test.ts but the unit-runner brace glob had no 'combo' entry, so its 4 tests were orphaned — check:test-discovery flagged a NEW orphan, a second latent red on release/v3.8.30. Add 'combo' to the glob across all lock-step collectors: the 7 package.json test scripts, build-test-impact-map.mjs, check-test-discovery.mjs and the 4 ci.yml run lines. Folded here (rather than a separate PR) because the two release reds are interdependent for Fast-QG: a package.json change triggers the full suite, so a combo-only PR would still trip the bailian red and vice-versa — fixing both in one PR is the only way to land a genuinely green Fast-QG. * chore(db): register apiKeyColumnFallbacks + apiKeyUsageLimitFields as db-internal The api-key usage-limits feature (migration 101) split two helper modules out of src/lib/db/apiKeys.ts — apiKeyColumnFallbacks.ts and apiKeyUsageLimitFields.ts — but did not register them with check:db-rules, so both were flagged as new db/ modules not re-exported by localDb.ts (Hard Rule diegosouzapw#2), a third latent red on release/v3.8.30. Both are imported only by db/apiKeys.ts (within src/lib/db/), so they are db-internal: add them to INTENTIONALLY_INTERNAL with that classification (mirrors healthCheck / stateReset) rather than re-exporting internal helpers onto the public localDb surface.
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…les count + diegosouzapw#4271 arena metadata) (diegosouzapw#4346) * test(db-rules): align audited-module count to 28 (apiKey db helpers) diegosouzapw#4335 added apiKeyColumnFallbacks + apiKeyUsageLimitFields to INTENTIONALLY_INTERNAL (both db-internal, consumed only by db/apiKeys.ts) but did not update the parity test in check-db-rules-classification.test.ts, which still expected exactly 26 audited modules — leaving it red on release/v3.8.30 (28 != 26). Add the two modules to the expected list and bump the count to 28. Test-only alignment; no production change. * test(web-session): align lmarena metadata to the split-cookie source (diegosouzapw#4271) diegosouzapw#4271/diegosouzapw#4331 updated webSessionCredentials.ts for lmarena's split auth cookie — new placeholder text and storageKeys arena-auth-prod-v1.0/.1 — but did not update web-session-credentials.test.ts, which still asserted the old placeholder + 3-key storageKeys. Align the expected metadata to the merged source; test-only, no prod change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores release/v3.8.30 to a green Fast-QG by fixing three latent reds, each introduced by a parallel-session merge that slipped past its own Fast-QG via test-impact-analysis selection. They are folded into one PR because they are interdependent for CI: a
package.json/ci.ymlchange forces the full unit suite + all gates (__RUN_ALL__), so any single-fix PR would still trip the others — fixing all three together is the only way to land a genuinely green Fast-QG.1. bailian-coding-plan static catalog ↔ registry parity (from #4324)
The provider-model sweep (#4324) added
qwen3.7-plus,qwen3-coder-plus,qwen3-coder-next,glm-4.7to thebailian-coding-planregistry entry but left the static fallback catalog (src/lib/providers/staticModels.ts) at the older six →bailian-coding-plan-provider.test.tsfailedStatic model count (6) should match registry (10). The mirror now carries all ten in registry order; the two legacy count/ID assertions are aligned.2. Collect orphaned tests/unit/combo/ (from #4326)
The ComboContext god-file split (#4326) added
tests/unit/combo/combo-context.test.ts, but the unit-runner brace glob had nocomboentry, so its 4 tests were never collected →check:test-discovery[órfão NOVO].combois added to every lock-step collector: 7package.jsontest scripts,build-test-impact-map.mjs,check-test-discovery.mjs, 4ci.ymlrun lines.3. Register api-key usage-limit db helpers (from migration 101)
The api-key usage-limits feature split
apiKeyColumnFallbacks.ts+apiKeyUsageLimitFields.tsout ofdb/apiKeys.tsbut didn't register them withcheck:db-rules→ flagged as newdb/modules not re-exported (Hard Rule #2). Both are imported only bydb/apiKeys.ts, so they aredb-internal: added toINTENTIONALLY_INTERNAL(mirrorshealthCheck/stateReset) rather than polluting the publiclocalDbsurface.Validation (Hard Rule #18)
All existing gates flipped RED→GREEN, verified locally:
bailian-coding-plan-provider.test.ts: 35/35.check:test-discovery: exit 0 (combo-context 4/4 now run).check:db-rules: exit 0.typecheck:core: all green.No user-facing behavior change beyond the bailian static fallback now advertising the same models the registry already had. Supersedes #4337 (combo-only).