refactor(compression): remove vestigial SLM seam + dead deprecated alias - #4253
Merged
diegosouzapw merged 1 commit intoJun 19, 2026
Merged
Conversation
Final dead-code/scaffold sweep for the "compression 100% functional" program. - ultra.ts: remove SLMInterface + createSLMStub. ultraCompress prunes inline via pruneByScore and never consumed the SLM seam — the real small-model path lives in the separate llmlingua engine (ONNX worker). The interface had zero production consumers; only its own tests exercised it. - stats.ts: remove estimateTokensForStats — a @deprecated alias of estimateCompressionTokens with zero callers. - index.ts: drop the corresponding re-exports. - ultra.test.ts: drop the createSLMStub block (the scaffold it tested is gone; the ultra engine's real behavior stays fully covered — 39 tests). Note (left as-is, larger call): the ultra config still carries modelPath / slmFallbackToAggressive, which ultraCompress also ignores — flagged for a separate decision (wire to llmlingua vs remove). Full compression suite 709/709 green; typecheck:core + lint clean.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
diegosouzapw
added a commit
that referenced
this pull request
Jun 19, 2026
… test-masking allowlist) Release-PR (→main) quality gates fired on cumulative cycle drift the PR→release fast-gates don't run: - eslintWarnings ratchet 3779 -> 3816: +37 `any` (warn-level) warnings from 115 cycle commits in open-sse/ and tests/. Release reconciliation adds 0 warnings (scripts/check/*.mjs are eslint-ignored; new fabricated-docs test uses no any). Same precedent as the v3.8.28 cycle-close rebaseline. Documented in baseline. - test-masking allowlist += 5 verified-legitimate net-assert reductions from merged refactors: #4129 (combo-routing-e2e alignment), #4226 (ccr-marker/session-dedup helper removal), #4253 (ultra SLM-seam removal), #4132 (db-backup de-flake). Each reduction removed/restructured asserts for removed code — not weakening.
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…ias (diegosouzapw#4253) Integrated into release/v3.8.29 — remove vestigial SLM seam (createSLMStub/SLMInterface) + dead estimateTokensForStats alias. Validated: ultra.test.ts 39/39 green, zero code callers of the removed symbols.
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…the llmlingua SLM tier (diegosouzapw#4257) Wire ultra's modelPath/slmFallbackToAggressive to the llmlingua SLM tier. Follow-up to diegosouzapw#4253. Integrated into release/v3.8.29.
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
… test-masking allowlist) Release-PR (→main) quality gates fired on cumulative cycle drift the PR→release fast-gates don't run: - eslintWarnings ratchet 3779 -> 3816: +37 `any` (warn-level) warnings from 115 cycle commits in open-sse/ and tests/. Release reconciliation adds 0 warnings (scripts/check/*.mjs are eslint-ignored; new fabricated-docs test uses no any). Same precedent as the v3.8.28 cycle-close rebaseline. Documented in baseline. - test-masking allowlist += 5 verified-legitimate net-assert reductions from merged refactors: diegosouzapw#4129 (combo-routing-e2e alignment), diegosouzapw#4226 (ccr-marker/session-dedup helper removal), diegosouzapw#4253 (ultra SLM-seam removal), diegosouzapw#4132 (db-backup de-flake). Each reduction removed/restructured asserts for removed code — not weakening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sweep final de dead-code/scaffold — encerra o "compressão 100% funcional"
Varredura de verificação de completude no subsistema achou 2 vestígios que escaparam do #4223:
1. Seam SLM morto (
ultra.ts)SLMInterface+createSLMStuberam um ponto de injeção de "small language model" para o engine ultra — nunca consumido.ultraCompresspoda inline viapruneByScore(linha 55) e o caminho de modelo real vive no engine llmlingua separado (worker ONNX). A interface tinha zero consumidores de produção; só os próprios testes a exercitavam.2. Alias
@deprecatedmorto (stats.ts)estimateTokensForStats= alias deestimateCompressionTokensmarcado@deprecated, com zero callers.Mudanças
ultra.ts: removeSLMInterface+createSLMStub.stats.ts: removeestimateTokensForStats.index.ts: remove os re-exports correspondentes.ultra.test.ts: remove o blocodescribe("createSLMStub")(o scaffold que ele testava sumiu; o comportamento real do ultra segue 100% coberto — 39 testes).Observação (deixada como está — decisão maior)
O config do ultra ainda carrega
modelPath/slmFallbackToAggressive, queultraCompresstambém ignora. Sinalizado para decisão separada (ligar ao llmlingua vs remover) — não toquei pois mexe em schema/DB/defaults.Validação: suíte de compressão 709/709 ✓ ·
typecheck:core✓ ·lint✓ · zero referências pendentes aos símbolos removidos.