Repository navigation
chore(compression): remove dead exports + fix stale llmlingua docs - #4223
Merged
diegosouzapw merged 1 commit intoJun 19, 2026
Merged
Conversation
Audit follow-up (compression "100% functional" program), part 1 of the vestigial cleanup. Pure removals of exported-but-unused symbols (no production or test caller — verified by grep) and a stale doc fix. No behavior change; the full compression suite stays green (690/690). Removed: - rtk/codeStripper.ts: stripCodeComments (+ its re-export from compression/index.ts) - rtk/commandDetector.ts: listCommandTypes - db/compression.ts: getDefaultAggressiveConfig / getDefaultUltraConfig / getDefaultRtkConfig (the DEFAULT_* constants they wrapped are exported and used directly) - headroom/gcf: dead imports (ATTACHMENT in generic.ts, isBareKey in decode_generic.ts) Un-exported (made module-private — still used internally): - rtk/filterSchema.ts: rtkFilterPackSchema, RtkFilterPack Doc fix: - llmlingua/index.ts: the "workerBackend is a stub today / L1 not-yet-done" comments were stale — worker.ts is the real MobileBERT ONNX worker-thread backend (stable since the 2026-06-16 VPS validation). Corrected to describe the real, fail-open backend. (The reconstruct* round-trip removal — which touches a live engine apply path — is part 2.)
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Jun 19, 2026
Merged
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…iegosouzapw#4223) Integrated into release/v3.8.29 (remove dead compression exports + fix stale llmlingua docs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
Programa compressão 100% funcional — item 7 (remover vestigial), parte 1/2 (a limpa/baixo-risco). Remoções puras de símbolos exportados-mas-sem-uso (verificado por grep: zero caller de produção ou teste) + 1 fix de doc mentiroso. Zero mudança de comportamento.
Removidos (dead exports)
rtk/codeStripper.ts:stripCodeComments(+ re-export emcompression/index.ts)rtk/commandDetector.ts:listCommandTypesdb/compression.ts:getDefaultAggressiveConfig/getDefaultUltraConfig/getDefaultRtkConfig(as constantesDEFAULT_*que eles envolviam já são exportadas e usadas direto)headroom/gcf: imports mortos (ATTACHMENTem generic.ts,isBareKeyem decode_generic.ts)Un-exportados (module-private — ainda usados internamente)
rtk/filterSchema.ts:rtkFilterPackSchema,RtkFilterPack(usados na uniãortkFilterSchema+isCanonicalFilter)Doc fix (mentiroso → real)
llmlingua/index.ts: os comentários "workerBackend é um stub today / L1 not-yet-done" estavam stale — ⭐ verifiqueiworker.ts: é o backend ONNX MobileBERT real (worker-thread, stable desde a validação VPS de 2026-06-16). Corrigido para descrever o backend real fail-open. (Os comentárioscall_logs follow-updo discover/learn foram mantidos — descrevem tarefa pendente, não falsidade.)Validação
typecheck:core✅ (sem imports/types órfãos) ·eslint✅ (0 erros; só warningsanypré-existentes).Parte 2 (PR seguinte)
A remoção dos
reconstruct{Headroom,Ccr,SessionDedup}— que toca oapplylive do session-dedup (reverse-map órfão) + 4 test files + gate de cobertura — vem separada por ser mais delicada.🤖 Generated with Claude Code