Skip to content

fix(codex): advertise gpt-5.4 models - #368

Merged
diegosouzapw merged 1 commit into
diegosouzapw:mainfrom
kfiramar:fix-codex-gpt54-models
Mar 14, 2026
Merged

diegosouzapw merged 1 commit into
diegosouzapw:mainfrom
kfiramar:fix-codex-gpt54-models

Conversation

@kfiramar

@kfiramar kfiramar commented Mar 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add gpt-5.4 to the Codex model registry
  • expose cx/gpt-5.4 and codex/gpt-5.4 in OmniRoute's model catalog
  • add a focused regression test for Codex model resolution

Testing

  • npm run test:plan3

Add gpt-5.4 to the Codex model registry so OmniRoute exposes cx/gpt-5.4 and codex/gpt-5.4 in its model catalog.

Includes a focused regression test for model resolution.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the gpt-5.4 model into the system by updating the Codex provider's model registry and ensuring its proper exposure within the OmniRoute model catalog. A dedicated regression test has been added to confirm that the gpt-5.4 model correctly resolves to the Codex provider, enhancing the robustness of model resolution.

Highlights

  • Model Registry Update: The gpt-5.4 model has been added to the Codex provider's model registry, making it available for use.
  • Model Catalog Exposure: The newly added gpt-5.4 model is now exposed in OmniRoute's model catalog, allowing it to be discovered and utilized.
  • Regression Test: A new regression test was introduced to specifically verify the correct resolution of the gpt-5.4 model to the Codex provider.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • open-sse/config/providerRegistry.ts
    • Added the gpt-5.4 model entry to the list of models under the Codex provider.
  • tests/unit/plan3-p0.test.mjs
    • Introduced a new unit test to confirm that getModelInfoCore correctly identifies gpt-5.4 as belonging to the codex provider.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the gpt-5.4 model to the Codex provider registry and adds a regression test to confirm its resolution. The changes update the model catalog and ensure proper model identification.

tokenUrl: "https://auth.openai.com/oauth/token",
},
models: [
{ id: "gpt-5.4", name: "GPT 5.4" },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new model gpt-5.4 has been added to the Codex registry. To improve clarity and maintainability, consider explicitly defining its maximum reasoning effort in the MAX_EFFORT_BY_MODEL map within open-sse/executors/codex.ts. While it currently defaults to "xhigh", an explicit entry would make its intended behavior clear and robust against future changes in default logic for new models.

@kilo-code-bot

kilo-code-bot Bot commented Mar 14, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 0

Analysis

The changes are correct:

  1. Model Registry (providerRegistry.ts:189): Added { id: "gpt-5.4", name: "GPT 5.4" } to the Codex provider's models array. This is the correct location since gpt-5.4 is a Codex-only model (not available in OpenAI's model catalog).

  2. Test (plan3-p0.test.mjs:26-30): The test correctly verifies that getModelInfoCore("gpt-5.4", {}) resolves to { provider: "codex", model: "gpt-5.4" }. The logic correctly identifies Codex as the sole provider for this model.

Note

An existing review comment already addresses a SUGGESTION regarding adding an explicit entry in MAX_EFFORT_BY_MODEL map in codex.ts. This is optional since models not in the map default to "xhigh" (unrestricted), which is the intended behavior.

Files Reviewed (2 files)
  • open-sse/config/providerRegistry.ts - Model registry change
  • tests/unit/plan3-p0.test.mjs - Regression test

@diegosouzapw
diegosouzapw merged commit ca78542 into diegosouzapw:main Mar 14, 2026
diegosouzapw added a commit that referenced this pull request Mar 14, 2026
- PR #368: gpt-5.4 in Codex model registry (cx/gpt-5.4, codex/gpt-5.4)
- PR #367: Codex fast tier toggle (default-off, full stack, 48 tests)
- PR #366: Codex quota policy 5h/weekly with auto-rotation
- fix #356: analytics charts show provider display names not raw IDs
prakersh pushed a commit to prakersh/OmniRoute that referenced this pull request Mar 26, 2026
Thanks @kfiramar! gpt-5.4 is now exposed in the model catalog as `cx/gpt-5.4` and `codex/gpt-5.4`. Minimal, tested fix — merged directly. 🙏
prakersh pushed a commit to prakersh/OmniRoute that referenced this pull request Mar 26, 2026
- PR diegosouzapw#368: gpt-5.4 in Codex model registry (cx/gpt-5.4, codex/gpt-5.4)
- PR diegosouzapw#367: Codex fast tier toggle (default-off, full stack, 48 tests)
- PR diegosouzapw#366: Codex quota policy 5h/weekly with auto-rotation
- fix diegosouzapw#356: analytics charts show provider display names not raw IDs
Poid-ZA pushed a commit to Poid-ZA/OmniRoute that referenced this pull request Aug 5, 2026
Thanks @kfiramar! gpt-5.4 is now exposed in the model catalog as `cx/gpt-5.4` and `codex/gpt-5.4`. Minimal, tested fix — merged directly. 🙏
Poid-ZA pushed a commit to Poid-ZA/OmniRoute that referenced this pull request Aug 5, 2026
- PR diegosouzapw#368: gpt-5.4 in Codex model registry (cx/gpt-5.4, codex/gpt-5.4)
- PR diegosouzapw#367: Codex fast tier toggle (default-off, full stack, 48 tests)
- PR diegosouzapw#366: Codex quota policy 5h/weekly with auto-rotation
- fix diegosouzapw#356: analytics charts show provider display names not raw IDs
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
Thanks @kfiramar! gpt-5.4 is now exposed in the model catalog as `cx/gpt-5.4` and `codex/gpt-5.4`. Minimal, tested fix — merged directly. 🙏
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
- PR diegosouzapw#368: gpt-5.4 in Codex model registry (cx/gpt-5.4, codex/gpt-5.4)
- PR diegosouzapw#367: Codex fast tier toggle (default-off, full stack, 48 tests)
- PR diegosouzapw#366: Codex quota policy 5h/weekly with auto-rotation
- fix diegosouzapw#356: analytics charts show provider display names not raw IDs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants