Skip to content

fix(codex): advertise gpt-5.4 models #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 1 commit into from
Mar 14, 2026
Merged

fix(codex): advertise gpt-5.4 models #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions open-sse/config/providerRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ export const REGISTRY: Record<string, RegistryEntry> = {
tokenUrl: "https://auth.openai.com/oauth/token",
},
models: [
{ id: "gpt-5.4", name: "GPT 5.4" },

@gemini-code-assist gemini-code-assist Bot Mar 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new model gpt-5.4 has been added to the Codex registry. To improve clarity and maintainability, consider explicitly defining its maximum reasoning effort in the MAX_EFFORT_BY_MODEL map within open-sse/executors/codex.ts. While it currently defaults to "xhigh", an explicit entry would make its intended behavior clear and robust against future changes in default logic for new models.

{ id: "gpt-5.3-codex", name: "GPT 5.3 Codex" },
{ id: "gpt-5.3-codex-xhigh", name: "GPT 5.3 Codex (xHigh)" },
{ id: "gpt-5.3-codex-high", name: "GPT 5.3 Codex (High)" },
Expand Down
6 changes: 6 additions & 0 deletions tests/unit/plan3-p0.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ test("getModelInfoCore keeps openai fallback for gpt-4o", async () => {
assert.equal(info.model, "gpt-4o");
});

test("getModelInfoCore resolves gpt-5.4 to codex", async () => {
const info = await getModelInfoCore("gpt-5.4", {});
assert.equal(info.provider, "codex");
assert.equal(info.model, "gpt-5.4");
});

test("getModelInfoCore returns explicit ambiguity metadata for ambiguous unprefixed model", async () => {
const info = await getModelInfoCore("claude-haiku-4.5", {});
assert.equal(info.provider, null);
Expand Down