refactor(dashboard): extract EditCompatibleNodeModal — #3501 Phase 1b

[diegosouzapw]

#3501 Phase 1b — Extract EditCompatibleNodeModal (cycle-safe)

Continues the decomposition (after Phase 0 #3633, Phase 1a #3634).

• Extracted EditCompatibleNodeModal (+ its *Node/*Props types) into providers/[id]/components/modals/.
• Moved the shared CC_COMPATIBLE_DEFAULT_CHAT_PATH constant into a new leaf module providerDetailConstants.ts so both the page client and the modal import it without a circular dependency (importing helpers from the client would create a cycle — the key constraint that gates which modals can move before the helpers→lib phase).
• Cleaned up two dangling section comments left behind by Phase 1a's removals.

ProviderDetailPageClient.tsx: 10,719 → 10,435 LOC.

Validation

• ✅ typecheck:core clean; lint 0 errors; prettier clean
• ✅ check:cycles: no cycles (the constant-into-leaf-module move is what keeps it acyclic)
• ✅ Phase 0 page smoke test green + new standalone EditCompatibleNodeModal render test (Hard Rule fix(oauth): prevent connection test from corrupting valid tokens #8)
• ✅ file-size ratchet lowered to 10,435

Note: the remaining modals (AddApiKeyModal, EditConnectionModal) each depend on ~15 shared module-scope helpers, so a helpers→lib extraction phase must land first (importing them from the client would cycle). That reordering is the next phase. Part of #3501. Co-authored with @oyi77.

[gemini-code-assist]

Code Review

This pull request extracts the EditCompatibleNodeModal component and its associated types from the large ProviderDetailPageClient.tsx file into a standalone modal component under components/modals/. It also moves the shared CC_COMPATIBLE_DEFAULT_CHAT_PATH constant to a new leaf module providerDetailConstants.ts to prevent circular dependencies, and adds a standalone test for the modal. The feedback points out that the newly added test file violates the repository style guide, which requires all test files to be placed strictly within the tests/ directory rather than co-located in the source tree.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

According to the Repository Style Guide (Section 1: File Placement & Organization), ALL unit tests, integration tests, ecosystem tests, or Vitest files MUST strictly be placed within the tests/ directory (e.g., tests/unit/, tests/integration/). Please move this test file to the appropriate subdirectory under tests/.

References

1. ALL unit tests, integration tests, ecosystem tests, or Vitest files MUST strictly be placed within the tests/ directory (e.g., tests/unit/, tests/integration/). ^(link)