fix(cli): Linux autostart via systemd user service (fixes #2627)

[janeza2]

Summary

Fixes #2627.

On headless Linux (e.g. Debian VPS, often as root), omniroute autostart enable reported success but OmniRoute did not start after reboot.

Root cause

• Autostart only created ~/.config/autostart/omniroute.desktop (XDG), which runs at graphical login, not at system boot.
• The desktop entry used serve --tray, which is not appropriate on headless servers.
• No systemd user unit was created, so journalctl showed nothing useful.

Changes

• Register a systemd user service at ~/.config/systemd/user/omniroute.service running serve --no-open.
• Run systemctl --user enable / start and loginctl enable-linger so the service can start after reboot without a desktop session.
• Resolve the CLI path reliably for global npm installs (realpath, command -v omniroute).
• On graphical sessions, still create the XDG .desktop entry with --tray.
• Extend omniroute autostart status with mechanism, paths, and linger state.

Test plan

• node --import tsx/esm --test tests/unit/cli-tray.test.ts tests/unit/cli/autostart.test.ts tests/unit/cli/autostart-linux.test.ts
• Debian headless: omniroute autostart enable → systemctl --user status omniroute is active; after reboot, service is running
• omniroute autostart disable removes the unit and stops the service
• Desktop Linux with DISPLAY or WAYLAND_DISPLAY: XDG autostart entry is still created

Fixes #2627

[kilo-code-bot]

Kilo Code Review could not run — your account is out of credits.

Add credits or switch to a free model to enable reviews on this change.

[gemini-code-assist]

Code Review

This pull request significantly enhances the autostart functionality across platforms, with a primary focus on Linux by introducing support for systemd user services and linger, alongside traditional XDG desktop autostart. The implementation refactors the autostart logic into a unified module, improves CLI path resolution robustness, and updates the CLI commands, documentation, and test suites accordingly. Review feedback identifies a logic error in the Linux enablement process that could lead to false-positive success reports, suggests simplifying redundant ternary logic in a systemctl execution helper, and recommends improving consistency in user identification when checking linger status.

[gemini-code-assist]

The fallback || existsSync(linuxSystemdUnitPath()) is problematic because the unit file was just written in the previous step (line 290), so this check will almost always be true. This causes ok to be true even if the systemctl --user enable command failed, leading to a false positive report that autostart is enabled when it actually isn't.

Suggested change

	ok = runUserSystemctl(`enable ${LINUX_SERVICE_NAME}`) || existsSync(linuxSystemdUnitPath());
	ok = runUserSystemctl(`enable ${LINUX_SERVICE_NAME}`);

[gemini-code-assist]

The ternary operator ignoreFailure ? false : false is redundant as it always returns false. Additionally, the ignoreFailure parameter is currently ignored in the error path. If the intention is to allow errors to propagate when ignoreFailure is false, the logic should be updated to throw the error.

Suggested change

	return ignoreFailure ? false : false;
	return false;

[gemini-code-assist]

For consistency with tryEnableLinger (lines 92-95), tryReadLingerEnabled should also attempt to fall back to whoami if the USER and LOGNAME environment variables are missing. This ensures the autostart status report is accurate in environments where these variables aren't set.

    const user =
      process.env.USER ||
      process.env.LOGNAME ||
      execSync("whoami", { encoding: "utf8", stdio: ["ignore", "pipe", "ignore"] }).trim();
    if (!user) return null;

[diegosouzapw]

Muito obrigado pela contribuição excelente, @janeza2! O suporte robusto para autostart via systemd no Linux headless foi integrado na release v3.8.3. Também adicionamos LOGNAME e XDG_CURRENT_DESKTOP à allowlist de verificação de variáveis de ambiente para passar na validação de CI e Husky hooks. Parabéns pelo ótimo trabalho! 🚀