Repository navigation
fix: bug-fix batch round 5 (#2504, #2515, #2520) - #2535
Conversation
…nt parts (#2515) #2504: thread _signatureNamespace through the FORMATS.GEMINI and FORMATS.GEMINI_CLI request translators so a cached Gemini thoughtSignature is re-attached to the functionCall on the follow-up turn (was 400 'missing thought_signature'). #2515: accept input_file (Responses API) on the Gemini path and document (Gemini-style) on the Responses/Codex path so PDFs reach the model regardless of content-part name.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
…destructive regen (#1622) The CLI key bootstrap wrote to ~/.omniroute/.env ignoring DATA_DIR, so users with a custom DATA_DIR (incl. Docker-style setups) lost the key across restarts. It also regenerated a fresh key whenever STORAGE_ENCRYPTION_KEY was unset — even when an encrypted storage.sqlite already existed — locking users out. Now writes to DATA_DIR and refuses to auto-generate when a database is already present (mirrors server bootstrapEnv guard). Reported by Daniel Nach; original key persistence by @Chewji9875.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e70b276b30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const file = toRecord( | ||
| contentItem.type === "document" ? contentItem.document : contentItem.file | ||
| ); |
There was a problem hiding this comment.
This branch claims to normalize bare data/url payloads, but it only reads nested contentItem.document/contentItem.file. If a client sends type:"document" (or type:"file") with top-level data/url fields, the translator emits {type:"input_file"} without file_data/file_url, which then reaches Responses/Codex as an empty file part and can trigger request rejection or dropped document input.
Useful? React with 👍 / 👎.
| const mimeTypeFallback = | ||
| rec.mime_type || | ||
| rec.media_type || | ||
| file?.mime_type || | ||
| doc?.mime_type || | ||
| "application/octet-stream"; | ||
| rec.mime_type || rec.media_type || file?.mime_type || doc?.mime_type || "application/pdf"; |
There was a problem hiding this comment.
Changing the fallback MIME from a generic value to application/pdf means any raw base64 file without explicit mime_type (for example text/CSV/other binaries) is now mislabeled as PDF. Gemini will parse those bytes as a PDF payload, which can cause malformed-document errors or incorrect file handling for non-PDF uploads that previously used a neutral type.
Useful? React with 👍 / 👎.
…ch-v3.8.2-r5 fix: bug-fix batch round 5 (diegosouzapw#2504, diegosouzapw#2515, diegosouzapw#2520)
1 participant
Summary
Round-5 bug-fix batch from
/resolve-issues-cc— 3 fixes with tests.[400]: Function call is missing a thought_signature in functionCall partson agentic tool use. The cachedthoughtSignature(keyed by connection + tool-call id) wasn't being re-attached becauseFORMATS.GEMINI/FORMATS.GEMINI_CLIrequest translators didn't thread the signature namespace. Now they do.input_fileworked for Codex but not Gemini;file/documentworked for Gemini but not Codex. Nowinput_fileis accepted on the Gemini path anddocument(+ baredata/url) on the Responses/Codex path, so a PDF reaches the model regardless of which name the client used.thinkingarrays /reasoning_details, e.g. Mistral/StepFun with lowmax_tokens) was misclassified as "Stream ended before producing useful content" and turned into a spurious 502.hasUsefulValuenow counts those carriers as valid output.Tests
stream-readiness.test.ts(+1, 12 total),translator-openai-to-gemini.test.ts(+3, 23 total). All green; full unit suite green on pre-push.Notes
[3.8.2]section (root + 41 i18n);check-docs-syncpasses.