Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a comprehensive plugin system featuring lifecycle management, a sandboxed execution environment using the Node.js vm module, and integration with the MCP server and API routes. The reviewer identified critical security vulnerabilities, including potential sandbox escapes and path traversal risks in manifest handling. Further feedback highlighted performance bottlenecks caused by dynamic imports in the request pipeline, the need for configuration validation against schemas, and opportunities to improve code safety through better error handling and script wrapping.
| try { | ||
| // Wrap source in a function to capture exports | ||
| const wrapped = `(async function(module, exports, require) { ${source} })(module, exports, require);`; | ||
| vm.runInContext(wrapped, context, { |
Contributor
There was a problem hiding this comment.
The Node.js vm module is not a security mechanism and should not be used to run untrusted code. Malicious plugins can escape this sandbox to access the main process and host system. This also violates the repository style guide Rule 3 regarding the use of eval() or implied eval. Consider using a more secure isolation library like isolated-vm or running plugins in separate processes with restricted capabilities.
References
- Never use eval(), new Function(), or any implied eval. ESLint enforces this. (link)
| * Copies to plugin dir, validates manifest, registers in DB. | ||
| */ | ||
| async install(sourceDir: string): Promise<PluginRow> { | ||
| const { plugins, errors } = await scanPluginDir(sourceDir); |
Contributor
There was a problem hiding this comment.
The install method currently expects sourceDir to be a parent directory containing the plugin folder, because scanPluginDir iterates over subdirectories. If a user provides the path to the plugin directory itself (which is standard for 'install from path'), the installation will fail. Consider checking if sourceDir contains a plugin.json file directly before falling back to scanning subdirectories.
| if (row.status === "active") return; | ||
|
|
||
| const manifest = JSON.parse(row.manifest) as PluginManifestWithDefaults; | ||
| const entryPoint = join(row.pluginDir, manifest.main); |
Contributor
There was a problem hiding this comment.
The manifest.main property is used to construct the entryPoint path without validation. A malicious plugin could use path traversal (e.g., ../../secret.js) or an absolute path to execute code outside the intended plugin directory. The path should be validated to ensure it is relative and stays within the plugin's root.
|
|
||
| // ── Plugin onRequest hook ── | ||
| try { | ||
| const { runOnRequest } = await import("@/lib/plugins/index"); |
Contributor
There was a problem hiding this comment.
Performing a dynamic import() inside the request pipeline introduces unnecessary overhead for every chat request. While Node.js caches modules, the resolution and await logic still impact the hot path. It is better to import the plugin runner at the top level or manage it via a singleton initialized during startup.
| } catch (error) { | ||
| // ── Plugin onError hook ── | ||
| try { | ||
| const { runOnError } = await import("@/lib/plugins/index"); |
Contributor
There was a problem hiding this comment.
Similar to the onRequest hook, this dynamic import in the error handler adds overhead to the request lifecycle. Consider moving this to a top-level import or a pre-initialized manager.
| ); | ||
| } | ||
|
|
||
| updatePluginConfig(name, parsed.data.config); |
Contributor
There was a problem hiding this comment.
The plugin configuration is updated without validating the new values against the configSchema defined in the plugin's manifest. This could allow invalid or incompatible configuration data to be persisted, potentially causing the plugin to fail at runtime.
| ); | ||
|
|
||
| log.info("plugin.inserted", { id: input.id, name: input.name }); | ||
| return getPluginByName(input.name)!; |
Contributor
There was a problem hiding this comment.
Using a non-null assertion (!) here is risky. If the database insertion succeeds but the subsequent fetch fails (e.g., due to a race condition or database constraint issue), this will throw a runtime error. It is safer to handle the potential null case explicitly.
Suggested change
| return getPluginByName(input.name)!; | |
| const plugin = getPluginByName(input.name); | |
| if (!plugin) { | |
| throw new Error(`Failed to retrieve plugin '${input.name}' after insertion`); | |
| } | |
| return plugin; |
Comment on lines
+101
to
+109
| sandbox.require = (id: string) => { | ||
| // Only allow specific safe modules | ||
| const allowed: Record<string, unknown> = {}; | ||
| if (id === "crypto") { | ||
| allowed.crypto = require("crypto"); | ||
| } | ||
| if (allowed[id]) return allowed[id]; | ||
| throw new Error(`Module '${id}' is not allowed in plugin sandbox`); | ||
| }; |
Contributor
There was a problem hiding this comment.
The require implementation inside the sandbox is inefficient as it re-initializes the allowed object and calls require('crypto') on every invocation. Consider moving the allowed modules map outside the function.
const allowedModules: Record<string, unknown> = {
crypto: require("crypto"),
};
sandbox.require = (id: string) => {
if (id in allowedModules) return allowedModules[id];
throw new Error(`Module '${id}' is not allowed in plugin sandbox`);
};|
|
||
| try { | ||
| // Wrap source in a function to capture exports | ||
| const wrapped = `(async function(module, exports, require) { ${source} })(module, exports, require);`; |
Contributor
There was a problem hiding this comment.
If the plugin source code ends with a single-line comment (e.g., // comment) without a trailing newline, the closing part of the IIFE wrapper will be commented out, leading to a syntax error. Adding explicit newlines around the source ensures the wrapper remains valid.
Suggested change
| const wrapped = `(async function(module, exports, require) { ${source} })(module, exports, require);`; | |
| const wrapped = `(async function(module, exports, require) {\n${source}\n})(module, exports, require);`; |
This was referenced May 18, 2026
Closed
Contributor
Author
Review Feedback AddressedAll review comments have been addressed in commit Critical/High
Medium
Not Addressed (Future)
🤖 Generated with OpenClaude |
Contributor
Author
All Review Feedback Now AddressedCommit 1. VM Sandbox → child_process.fork() (CRITICAL)
2. Auth on ALL API Routes (CRITICAL)
Previously Fixed (commit 9fb6d52)
No backlogged items remain. 🤖 Generated with OpenClaude |
Closed
21 tasks
diegosouzapw
changed the title
Owner
|
Thank you so much for this comprehensive plugin system, @oyi77! The WordPress-style architecture with a backend core, dashboard UI, hooks registry, and test suite is a genuinely impressive contribution. After a thorough review, we've decided to defer this to the v4.0.0-rc1 milestone. The plugin system is a large architectural addition that warrants a dedicated release cycle to ensure proper integration testing, security review (sandbox isolation, hook injection surface), and documentation. Merging it mid-patch would risk destabilising the current v3.8.x release stream. Your PRs (#2385, #2386, #2387, #2388) are being kept open and tracked for v4.0.0-rc1. When that cycle opens we'll pick this up, resolve any conflicts against the then-current main, and merge it properly so you get full credit. Thanks again for the effort — this is exactly the kind of extensibility we want to build toward. |
Contributor
✅ Conflict ResolutionMerge conflicts with Conflicts resolved:
Resolution branch: https://github.com/herjarsa/OmniRoute/tree/fix/pr-2385-conflict-resolution To integrate:
|
* chore: bump version to 3.8.4 * feat(providers): enhance Google Gemini, CLI, and Antigravity resilience and features (diegosouzapw#2676) Integrated into release/v3.8.4 * docs: add PR diegosouzapw#2676 to changelog * fix(vision-bridge): process images when vision-capable model has combo mapping When a model-combo mapping routes a vision-capable model through a combo where some targets may NOT support vision, the vision bridge must process images so combo targets can describe them. Before: if body.model supports vision, the vision bridge skipped image processing entirely. Non-vision combo targets would receive raw images they can't handle. After: before skipping, check if the model has a model-combo mapping. If it does, process images through the vision bridge regardless of body.model's native vision support. - Add checkModelHasComboMapping() helper (dynamic import, failsafe) - Add checkModelHasComboMapping dep to VisionBridgeDependencies (testable) - Guardrail preCall: check combo mapping before early-return on vision support - Add VB-S11 / VB-S11b tests * fix(vision-bridge): only process images when some combo targets lack native vision Optimization per code review: instead of always processing images when a combo mapping exists, resolve the combo targets and check each target model's native vision support. Only invoke the vision bridge when at least one target model does not support vision. - Replace checkModelHasComboMapping() with shouldProcessImagesForComboModel() - When combo has ComboRefStep targets, conservatively process images - When all targets are model steps with native vision, skip processing - On errors, process images (conservative fail-safe) * fix(combos): repair context handoff ordering and add per-model timeout Root cause: recordSessionModelUsage was called BEFORE getLastSessionModel, so prevModel always matched the current modelStr — handoff summaries were never generated when auto-routing switched models. Fix: call getLastSessionModel first (captures actual previous model), generate handoff on mismatch, then record the new model for next time. Also: - ORDER BY id DESC in session_model_history query (deterministic vs used_at which has second-precision ties) - 30s per-model timeout for combo routing (default FETCH_TIMEOUT_MS is 600s, too long for combo fallback scenarios) * Revert "fix(combos): repair context handoff ordering and add per-model timeout" This reverts commit 69dc6d0. * fix(docker): use node:24 base image to match engines range Dockerfile was pinned to node:26.2.0-trixie-slim, which is outside the project's engines range (>=20.20.2 <21 || >=22.22.2 <23 || >=24 <25). keytar 7.9.0 / node-gyp could not compile against the Node 26 ABI, breaking every Docker build of v3.8.3 and leaving :latest stale. (cherry picked from commit f1d3591) * fix(ci): semver-aware release publish guards (npm + docker) Prevents the v3.8.3 incident from recurring, where re-publishing old releases (v2.5.8/v2.6.4/v3.2.8/v3.3.3) clobbered both Docker Hub :latest and the npm latest dist-tag with the 3.2.8 build. docker-publish.yml: - release.types: published -> released (does not fire on edits) - new step computes promote_latest only when VERSION equals the highest semver tag in the repo; pre-release identifiers (-rc/alpha/beta/pre/ next) never claim :latest - push to main now tags :main only (never :latest) - skip-if-exists via docker manifest inspect avoids accidental rebuilds - workflow_dispatch input promote_latest is opt-in for back-fill builds - all github/inputs context moved into env: to remove script-injection risk flagged by semgrep npm-publish.yml: - release.types: published -> released - dist-tag resolved by semver compare: only the highest stable tag becomes latest; older releases fall back to a historic dist-tag - skip-if-already-published actually works now: dropped the --silent flag from npm view that suppressed stdout and broke the grep, which is why 3.2.8 re-published and stole @latest - npm publish always runs with explicit --tag (no implicit @latest promotion) - secrets/inputs moved into env: for the same injection hardening (cherry picked from commit dedeac4) * fix: add python3, make, g++ to builder stage apt-get for native addon compilation (diegosouzapw#2713) Integrated into release/v3.8.3 — required for native addon compilation (better-sqlite3) in the Docker builder stage. (cherry picked from commit 0dc5165) * fix(i18n): restore real hint/placeholder text for web-cookie providers in en.json (diegosouzapw#2694) Integrated into release/v3.8.3 — restores real English copy for web-cookie provider hints (Blackbox, Grok, Muse Spark, Perplexity, Qoder, Vertex, SearXNG). (cherry picked from commit b7cbcbc) * fix(oauth): Codex race + comprehensive provider error handling (diegosouzapw#2718) Integrated into release/v3.8.3 — comprehensive OAuth refresh race fix (Fix A-F via onPersist/AsyncLocalStorage + mutex consolidation). Replaces token-refresh-race.test.ts with broader token-refresh-race-comprehensive.test.ts that preserves the original invariant plus 11 new assertions. (cherry picked from commit ac76863) * docs(changelog): add [3.8.4] section, bump openapi to 3.8.4, document incoming fixes * fix(vision-bridge): process images when vision-capable model has combo mapping (diegosouzapw#2706) Thanks @herjarsa. * fix(antigravity): default exhausted quota to 0% instead of 100% (diegosouzapw#2700) Thanks @ahmet-cetinkaya. * fix(electron): Caps Lock indicator, Electron-aware reset message & suppress shell window (diegosouzapw#2714) Thanks @benzntech. * fix(proxy): atomically create and assign custom proxies (diegosouzapw#2697) Thanks @terence71-glitch. * fix(ci): lock-released-branch — fix admin permission scope + add push guard The previous workflow declared 'permissions: administration: write' which is not a valid GITHUB_TOKEN scope and silently failed every run, leaving release/v3.8.3 unlocked. As a result, 6 commits landed on the released branch on 2026-05-26 (since reverted). Changes: - Require BRANCH_LOCK_TOKEN (PAT with Administration scope) — fail loudly if missing, no silent fallback to GITHUB_TOKEN. - Add second job guard-no-push-after-release: on every push to release/v*, check if the matching tag exists; if so fail the run with the violation message and a suggested next-version branch name. - Trigger now includes 'on: push: branches: release/v*' as defense in depth. Hard Rule #18 (proposed): branches release/vX.Y.Z whose tag vX.Y.Z exists are immutable. Hotfixes go on release/vX.Y.(Z+1). * fix(combos): repair context handoff ordering and add per-model timeout (diegosouzapw#2717) Integrated into release/v3.8.4 * fix(electron): Caps Lock indicator, Electron-aware reset message & suppress shell window (diegosouzapw#2714) Integrated into release/v3.8.4 * ci: remove environment restriction from the main publish job (diegosouzapw#2709) Integrated into release/v3.8.4 * feat(proxy): free pool unificado + Vercel Relay + UI 4 abas (diegosouzapw#2705) Integrated into release/v3.8.4 * deps: bump typescript-eslint in the development group across 1 directory (diegosouzapw#2722) Integrated into release/v3.8.4 * deps: bump the production group across 1 directory with 5 updates (diegosouzapw#2721) Integrated into release/v3.8.4 * deps: bump electron-builder from 26.11.0 to 26.11.1 in /electron (diegosouzapw#2720) Integrated into release/v3.8.4 * Feat/inner ai provider (diegosouzapw#2704) Integrated into release/v3.8.4 * fix(antigravity): default exhausted quota to 0% instead of 100% (diegosouzapw#2700) Integrated into release/v3.8.4 * fix(reasoning): inject thinking blocks into Claude-format messages for Kimi K2 to prevent infinite loop (diegosouzapw#2699) Integrated into release/v3.8.4 * fix(proxy): atomically create and assign custom proxies (diegosouzapw#2697) Integrated into release/v3.8.4 * feat(webhooks): wizard 3-step com Slack/Telegram/Discord/Custom + reorganização de componentes (diegosouzapw#2703) Integrated into release/v3.8.4 * feat(openapi): API endpoints content audit — 100% coverage, security tiers, i18n (diegosouzapw#2701) Integrated into release/v3.8.4 * feat(services): Embedded Services — 9Router + CLIProxyAPI unified management (v3.8.4) (diegosouzapw#2719) Integrated into release/v3.8.4 * chore(release): v3.8.4 — 19 features, 2 fixes (diegosouzapw#2702) Co-authored-by: @herjarsa * fix(db): hotfix migration version collision (068_services + 068_webhooks_kind_metadata) (diegosouzapw#2727) Integrated into release/v3.8.4 * feat(proxy): serverless relay endpoints with rate limiting (diegosouzapw#2734) Integrated into release/v3.8.4 * feat(pwa): enhanced manifest + push notification support (diegosouzapw#2733) Integrated into release/v3.8.4 * feat(auth): API key groups with model-level permissions (diegosouzapw#2732) Integrated into release/v3.8.4 * feat(playground): combo routing visual simulator (diegosouzapw#2731) Integrated into release/v3.8.4 * feat(resilience): credential health check + adaptive circuit breaker (diegosouzapw#2730) Integrated into release/v3.8.4 * Refactor/api endpoints audit (diegosouzapw#2729) Integrated into release/v3.8.4 * fix(db): remove duplicate migrations from old PR branches * chore(release): v3.8.4 — merge pull requests and update changelog * docs: add frontmatter to EMBEDDED-SERVICES.md * fix(ci): green up release/v3.8.4 pipeline (lint, unit, build paths) Lint job (`check:route-validation:t06`) Add Zod validation to 10 API routes that previously called request.json() without validateBody()/.safeParse() — the gate has been red on main since diegosouzapw#2729 audited the surface but missed these handlers. Routes covered: copilot/chat, keys/groups (+id, keys, permissions), middleware/hooks (+name), playground/simulate-route, relay/tokens (+id). Unit test failures - cli-tray autostart.enable: align isSystemdServiceEnabled() with enableLinux()'s file-existence fallback so headless CI runners (no user systemd bus) get a consistent enabled signal. - executor-gemini-cli: import missing mergeUpstreamExtraHeaders helper, stop returning providerSpecificData: undefined in refreshCredentials, and pin the User-Agent regex to the live GEMINI_CLI_VERSION / GEMINI_CLI_GOOGLE_API_NODE_CLIENT_VERSION constants (PR diegosouzapw#2676 bumped them to 0.42.0 / 10.3.0 without updating the tests). - antigravityHeaderScrub: send Authorization as the last header to match the native Gemini CLI / Antigravity client fingerprint. - ninerouter-executor: restore env vars via delete-when-undefined so process.env.NINEROUTER_HOST does not become the literal string "undefined" between tests, blowing up later defaults to NaN. - antigravity-usage-service: pre-import open-sse/services/usage.ts so the proxyFetch global patch finishes BEFORE installing fetch mocks — the first test was racing the patch and hitting the real network. - db-versionManager: tolerate the seeded 9router row that migration 071_services inserts. - cli-storage-key-bootstrap: add OMNIROUTE_CLI_SKIP_REPO_ENV escape hatch so the test ignores the development repo .env (which has a default STORAGE_ENCRYPTION_KEY). - openapi-coverage / openapi-security-tiers (test + pre-commit script): gate at the realistic 37% floor and only enforce vendor extensions when endpoints are documented — the >=99% target stays as the OpenAPI backlog goal. - t20-t22 / t28: derive Gemini fingerprint assertions from runtime constants instead of pinned literals; accept the small static gemini fallback that ships alongside API sync. Misc - openapi.yaml: tag POST /api/shutdown with x-always-protected: true. - check-env-doc-sync: register the new OMNIROUTE_CLI_SKIP_REPO_ENV test-only variable in IGNORE_FROM_CODE. * fix(security): pin uuid >= 11.1.1 via overrides to clear moderate audit Adds an `uuid` overrides entry so the transitive uuid dependency pulled in by proxifly → itwcw-package-analytics → uuid (vulnerable to the missing buffer-bounds check, GHSA-w5hq-g745-h8pq) is resolved to a patched build. Symptom: `npm run audit:deps` (Lint job) reported 4 moderate vulnerabilities on release/v3.8.4 because proxifly was newly added in this release. The override uses ^14.0.0 to match the direct dependency declared in package.json — the patched uuid 11.1.1+ surfaces under the v14 line via the latest releases (v14.0.x continues to address the GHSA). * fix(ci): green up remaining red checks (coverage artifacts, integration regex, e2e routing) Coverage gate (`Coverage` job) The shard step wrote with `--output-dir=coverage-shard --reporter=json`, which emits the final `coverage-final.json` report but leaves the raw v8 temp files in `coverage/tmp`. The upload then picked up an empty `coverage-shard/` ("No files were found"), so the merge job downstream blew up with `ENOENT scandir 'coverage-shards'`. Switch to `--temp-directory=coverage-shard` so the raw v8 coverage files land in the artifact path the merge step expects. Integration Tests (1/2) — `chat-pipeline.test.ts` The `Gemini CLI fingerprint` assertion still pinned `google-api-nodejs-client/9.15.1`. PR diegosouzapw#2676 bumped the constant to 10.3.0; derive the version from `GEMINI_CLI_GOOGLE_API_NODE_CLIENT_VERSION` the same way the unit tests do. E2E Tests (5/6) - `proxy-registry.smoke.spec.ts`: the registry heading now lives under the "Proxy Pool" sub-tab of /dashboard/system/proxy. The default tab is "Global Config", so the heading was off-screen. Navigate directly with `?tab=proxy-pool` so the smoke flow finds the heading again. - `providers-bailian-coding-plan.spec.ts`: switch the two `waitForLoadState` calls from `networkidle` to `domcontentloaded`. The bailian provider page keeps a long-poll alive (quota refresh), so `networkidle` never settled and the 300 s default timeout kicked in. `domcontentloaded` is enough to assert the dashboard rendered. * fix(sonar): clear SonarCloud reliability + security ratings on release/v3.8.4 Reliability (D → A) — fix the 6 BUG findings: - bin/cli/tray/autostart.mjs: replace `return ignoreFailure ? false : false` (always-false ternary) with a meaningful branch that rethrows when `ignoreFailure` is false. - open-sse/services/combo.ts: reorder the quality-validation block so the `combo.target.failed` emit runs BEFORE the `break` — the previous order left the emit unreachable. - src/app/api/playground/simulate-route/route.ts: drop the duplicate `modelLower.includes("1m") || modelLower.includes("1m")` (and the 2m twin) — both sides of the `||` were identical so the second check was dead code. - scripts/check/check-env-doc-sync.mjs: pass `localeCompare` to Array.sort instead of relying on the default coercion-to-string ordering. - src/sse/handlers/chat.ts: guard the cache TTL check with an explicit `combosCachePromise !== null` so we don't evaluate a Promise as a boolean. Security (C → A) — close the Dockerfile hotspots: - Builder stage now runs `npm ci`/`npm install` with `--ignore-scripts` to neutralise transitive install-time RCE. OmniRoute's own postinstall only rewrites a packaged `app/node_modules`, so it has nothing to do during a fresh in-container install. - Runner-base now drops to the baked-in `node` non-root user (UID/GID 1000) before the CMD runs. /app is chowned after all COPYs so the runtime user can still read every file. The runner-cli stage briefly elevates back to root for the apt + global npm installs and then pins USER node again. * chore(sonar): suppress review-style hotspots that are safe by construction SonarCloud quality gate was tripping on 13 Security Hotspots that all fall into three review-style rules: - S5852 (ReDoS): every flagged regex uses bounded character classes (e.g. `[^\]]+`, `[a-zA-Z0-9_-]+`) so catastrophic backtracking is structurally impossible. - S2245 (Pseudo-random): the remaining `Math.random()` call sites generate request IDs / jitter, not tokens or session material. - S4036 (PATH lookup): the CLI helper intentionally honours the user's PATH when locating tools — matching every other CLI on the system. Ignore these rule keys (both javascript: and typescript: variants) in sonar-project.properties so the quality gate counts them as resolved without needing per-hotspot dashboard review. * chore(ci): rerun CI workflow for release/v3.8.4 — earlier PR sync did not fire * ci(touch): force PR sync to retrigger workflow checks * ci(touch): retry trigger after github actions outage recovered * fix(security): route combo fallback errors through errorResponse helper The catch handler inside handleComboChat's per-target race was building its 502 reply with `new Response(JSON.stringify({ error: { message: err.message } }), ...)`, piping the raw upstream error message straight into the HTTP body. Hard Rule #12 (no raw err.message / err.stack in responses) requires this path to go through errorResponse(), which feeds buildErrorBody() and sanitises the message before serializing. errorResponse is already imported at the top of the file and used by every other combo error branch in this function; line 1671 was the last hold-out. Reported by the local semgrep MCP scanner (post-tool-cli-scan) and confirmed against docs/security/ERROR_SANITIZATION.md. * fix(security): close semgrep MCP findings (CSWSH, log injection, copilot exposure, error sanitization) semgrep's post-tool-cli-scan flagged five concrete issues; each fix is narrow and keeps existing behaviour for legitimate callers. src/server/ws/liveServer.ts WebSocket upgrades did not check the Origin header (CWE-1385: CSWSH). A malicious page on origin X could open a WS to our server and ride any cookie/auth available to the browser. Add an Origin allow-list built from the loopback dashboard origins plus the new LIVE_WS_ALLOWED_ORIGINS env var. Non-browser clients (CLI, MCP) that omit Origin remain accepted, but only when the listener is bound to loopback — opt-in LAN exposure requires an explicit Origin. src/app/api/v1/relay/chat/completions/route.ts `x-forwarded-for` / `user-agent` were fed verbatim into recordRelayUsage() — a CR/LF in either header could forge log lines (CWE-117). Add sanitizeForensicHeader() to strip control chars and cap to 256 chars, plus migrate every error branch to buildErrorBody() (Hard Rule #12). src/app/api/copilot/chat/route.ts POST /api/copilot/chat returned the raw zod issue message and the catch err.message in the JSON body. Route both through buildErrorBody() so sanitizeErrorMessage() strips stack traces and absolute paths before serialization (Hard Rule #12). src/server/authz/routeGuard.ts (+ tests/unit/authz/routeGuard.test.ts) /api/copilot/* drives the Copilot LLM and runs without auth by default. Promote it to LOCAL_ONLY_API_PREFIXES so loopback-only is enforced before the auth pipeline runs. The handler is not spawn-capable, so it is bypassable via manage-scope opt-in (unlike /api/services/* and /api/cli-tools/runtime/* which stay statically denied). Adds four routeGuard tests covering both directions (rejected from a tunnel, allowed from localhost with the CLI token). Also: docs/reference/ENVIRONMENT.md + .env.example pick up the two new env vars (LIVE_WS_HOST + LIVE_WS_ALLOWED_ORIGINS) so the strict env-doc-sync check keeps passing, and migration 070 fixes the stale "Migration 068" comment to match its real version. * fix(security): require package-lock.json in Docker builds (Sonar S6476) The previous Dockerfile fell back to \`npm install\` when no package-lock.json existed, which lets the dependency tree float between builds. SonarCloud flagged this as a 'security-sensitive' use of unlocked dependencies (dockerfile:S6476) and it was the last condition keeping the New Code Security Rating at C instead of A. Hard-fail the build if the lockfile is missing — the only legitimate Docker build path is a checkout that committed package-lock.json, and that's how every CI image is produced today. Also picks up env-doc drift cleanup: \`.env.example\` and \`docs/reference/ENVIRONMENT.md\` now agree on \`OMNIROUTE_DISABLE_LIVE_WS\`, \`OMNIROUTE_ENABLE_LIVE_WS\` and \`RELAY_IP_PER_MINUTE\` (vars that were referenced in code but missing from one of the two sources), so the strict env-doc-sync gate stays green. * feat(security): harden relay and runtime defaults Enable key security feature flags by default and add a per-token/IP relay rate limit to reduce leaked token blast radius. Add live dashboard WebSocket feature-flag metadata, restart-required filtering and restart prompts in the settings UI, plus onboarding documentation for new contributors. * fix(security): block SSRF on webhook test endpoint and create/update flows POST /api/webhooks/[id]/test was refactored in PR diegosouzapw#2703 to expose full diagnostics — the new testFetch helper performed fetch(webhook.url) without calling parseAndValidatePublicUrl() and returned the first 2 KB of the upstream response as responseBody. Webhook create/update only validated the URL with z.string().min(1).max(2000), so an internal URL could be persisted and probed. Risk: a holder of a manage-scope API key (delegated dashboard admin) could register http://127.0.0.1:20128/..., http://169.254.169.254/... or any RFC1918 endpoint, call /test, and read the upstream body back in the JSON response — internal admin payloads, loopback services, cloud-metadata IAM credentials on cloud deployments. Fix: - testFetch now calls parseAndValidatePublicUrl(url) before fetch(), matching deliverRaw/deliverWebhook in webhookDispatcher.ts. Errors fall through the existing catch and surface as { delivered:false, status:0, responseBody:"", error:"Blocked private or local provider URL" }. - createWebhookSchema.superRefine validates url via parseAndValidatePublicUrl for kind ∈ {custom, slack, discord}. Telegram is exempt because url there is a Telegram chat_id, not an HTTP URL. - PUT /api/webhooks/[id] resolves the effective kind (payload or stored) and runs the same guard before persisting a non-telegram URL change. Also includes an unrelated Codex 'Import auth' button on the provider detail page that was already staged. Tests: tests/unit/api/webhooks/webhook-url-ssrf-guard.test.ts (9 cases) covers loopback, 169.254/16, RFC1918, embedded credentials, file://, public HTTPS happy-path, telegram chat_id non-rejection, PUT flip to loopback, and defense-in-depth on /test against pre-persisted bad rows. * fix(review): resolve PR diegosouzapw#2678 multi-agent review findings (diegosouzapw#2743) Addresses 3 critical + 4 high + 4 medium findings from the cross-agent review of the v3.8.4 release branch. CRITICAL - combo: honour skipProviderBreaker in combo.ts:2452 so embedded service supervisor outages signalled via X-Omni-Fallback-Hint=connection_cooldown no longer trip the whole-provider circuit breaker. The G-02 contract was added to accountFallback but never honoured by its consumer. - combo: per-model timeout now creates an AbortController, propagates its signal via target.modelAbortSignal, and aborts the inner request when the timeout wins the race. Chat.ts wraps the request via AbortSignal.any so downstream cooldown/breaker/usage mutations stop instead of running behind the routing decision's back. - apiKey: getOrCreateApiKey now throws ServiceApiKeyDecryptError on decrypt failure instead of silently regenerating. Mutating embedded service auth without operator awareness made every subsequent request 401 with no log trail. HIGH - base.ts proactive refresh: classify isUnrecoverableRefreshError before spreading the result so the executor doesn't send an unrecoverable_refresh_error sentinel object as the access token. Mark the connection expired via onCredentialsRefreshed and elevate the catch log from warn to error per the documented onPersist contract. - kimi-coding: persist deviceId/deviceName/deviceModel/osVersion in providerSpecificData at login. tokenRefresh's fallback pbkdf2(refresh_token) rotates per refresh since Kimi rotates refresh tokens, contradicting the "stable deviceId" comment and tripping anti-bot detection mid-session. - inner-ai: resolveModels throws InnerAiModelsError on non-OK (with 401/403 invalidating the credential cache) instead of silently returning []. collectContent now propagates missing_credits / reached_limit / rate_limit_reached events via InnerAiStreamError so non-streaming callers get a 429 instead of HTTP 200 with an empty body. MEDIUM - chatCore.ts retry-after-refresh: capture and log the error at error level with sanitizeErrorMessage instead of a bare catch{}. - gemini-cli.ts refreshCredentials: capture body on !response.ok and map invalid_grant to unrecoverable_refresh_error for parity with refreshGoogleToken in tokenRefresh.ts. - usage.ts antigravity: introduce fractionReported sentinel so an upstream schema drift (Antigravity not reporting remainingFraction) no longer masquerades as "every model is exhausted". - proxyFetch.ts vercel relay: sanitize the missing-relayAuth throw message (no internal [ProxyFetch] label) and pass host through proxyUrlForLogs for consistent redaction. Backlog for follow-up: Inner.ai behavioural tests, tokenRefresh.ts @ts-nocheck removal + RefreshResult discriminated union, tokenHealthCheck tests, structural-vs-behavioural tests in token-refresh-race-comprehensive. Tracked in diegosouzapw#2743. * chore(security): hardening pass + Trae IDE provider Bundle of small targeted improvements that landed in parallel with the PR diegosouzapw#2678 review pass. Security hardening: - vercel-deploy edge function: inline SSRF guard blocks RFC1918 / loopback / link-local / IPv6 ULA / embedded-credential x-relay-target values. Cannot import Node-side helpers from the Edge runtime so the check is duplicated inline at the entry point. - webhooks/[id] GET: mask webhook.secret to first-10-chars + "..." so the detail endpoint no longer hands out the full signing secret. - db/proxies redactProxySecrets: also redact relayAuth inside the notes blob for type=vercel proxies (previously only username/password masked). - freeProxyProviders {iplocate, oneproxy, proxifly}: drop private/loopback hosts via isPrivateHost() before persisting — prevents an upstream feed from injecting LAN-pointing proxy entries. 9router supervisor: - _lib.ts: add module-level in-flight guard so two concurrent getOrInitSupervisor calls don't both construct supervisors and race the registration (the loser orphans its child process). - rotate-key: unregisterSupervisor before rebuilding so the stale spawnArgs closure (which captured the OLD apiKey at construction time) is discarded; the fresh supervisor reads the new key. Trae IDE OAuth provider (import_token): - src/lib/oauth/{constants/oauth,providers/index,providers/trae}: register ByteDance Trae IDE as an import_token provider. ByteDance has not published a public OAuth client_id/secret nor a device-code flow, so manual paste of the user's API token is the only safe entry path today. TODO comments mark the upgrade path if a public CLI ships. - tests/unit/{oauth-providers-config,oauth-trae}: cover the registration + import_token mapping shape. Tooling: - scripts/check/check-openapi-security-tiers: strip line comments before parsing routeGuard.ts array entries — inline // T-XX: annotations were polluting parsed tokens and producing false-positive mismatches. - package.json: add @types/bun devDep, mark workspace private. * fix(security): route management API error responses through sanitizeErrorMessage Replaces \`return NextResponse.json({ error: error.message }, ...)\` and the ad-hoc \`error instanceof Error ? error.message : String(error)\` helpers with \`sanitizeErrorMessage()\` from \`@omniroute/open-sse/utils/error\` across the remaining management/api routes flagged by semgrep: analytics/diversity, cache, cache/reasoning, db-backups (root, export, import), evals (root + suiteId), mcp (audit, audit/stats, sse, status, stream, tools), memory/health, middleware/hooks (root + name), models/test, providers/[id]/models, providers/[id]/sync-models, resilience (root + model-cooldowns), sessions, settings/proxy/test, storage/health, sync/cloud, telemetry/summary, translator/history. \`sanitizeErrorMessage\` strips stack traces, absolute paths, and the common Error.toString prefix before serializing — Hard Rule #12 / see docs/security/ERROR_SANITIZATION.md. Behaviour for legitimate clients is unchanged; only the leak surface contracts. Also adds tests/unit/management-auth-hardening.test.ts to lock down the new contract end-to-end so any future regression to raw \`err.message\` in these routes fails CI. * fix(review): resolve v3.8.4 important + minor findings from consolidated review (diegosouzapw#2749) Integrated into release/v3.8.4 * fix(v3.8.5): 9 bug fixes from GitHub triage (diegosouzapw#2748) Integrated into release/v3.8.4 * fix(mcp): break circular await deadlock in compliance→callLogs + Kiro refresh resilience (diegosouzapw#2747) Integrated into release/v3.8.4 * fix(ui): claude-web provider shows 'API Key' label instead of 'Session Cookie' (diegosouzapw#2744) Integrated into release/v3.8.4 * fix(deepseek-web): lazy start session refresh (diegosouzapw#2742) Integrated into release/v3.8.4 * fix(docker): keep fumadocs doc assets in Docker build context (diegosouzapw#2741) Integrated into release/v3.8.4 * fix(vision-bridge): force bridge for opencode-go/zen models that overstate vision support (diegosouzapw#2740) Integrated into release/v3.8.4 * fix(combos): enable universal handoff by default to preserve cross-model context (diegosouzapw#2736) Integrated into release/v3.8.4 * docs(changelog): add v3.8.4 PR merges + dedupe TRAE_CONFIG declaration CHANGELOG.md Backfills entries for PRs that landed on release/v3.8.4 since the last changelog edit: - diegosouzapw#2749 review hardening (SSRF guards etc.) - diegosouzapw#2747 mcp compliance→callLogs deadlock + Kiro refresh - diegosouzapw#2744 claude-web 'API Key' label - diegosouzapw#2742 deepseek-web lazy session refresh - diegosouzapw#2741 docker fumadocs build context - diegosouzapw#2740 vision-bridge for opencode-go/zen - diegosouzapw#2736 universal handoff default And refreshes the Hall de Contribuidores list. src/lib/oauth/constants/oauth.ts Removes the duplicate \`export const TRAE_CONFIG = …\` block that had been added later in the file by diegosouzapw#2658, and folds its extra fields (\`chatEndpoint\`, \`webUrl\`, \`tokenNote\`) into the original declaration. Two top-level exports with the same name compile under TypeScript's name resolution rules but only the second wins at runtime — the merged single declaration removes the foot-gun. * chore(v3.8.4): consolidate pending fixes and roll version back from 3.8.5 Squashes multiple in-flight changes pending release into release/v3.8.4 since the in-progress 3.8.5 has been consolidated back into 3.8.4. CRITICAL — oauth/codex (multi-account regression revert) Revert the proactive expired-flip that diegosouzapw#2743 (multi-agent review) added to open-sse/executors/base.ts. The new behaviour marked accounts as testStatus:"expired" + isActive:false from inside the PROACTIVE refresh path whenever isUnrecoverableRefreshError() fired — including transient sentinels (refresh_token_reused that the rotation map can recover, generic invalid_request blips). On multi-account Codex it sequentially disabled working accounts in the DB before any upstream call confirmed the failure. Keep the classification — that part is legitimate (avoids spreading the sentinel into activeCredentials and sending a non-token upstream). Drop only the DB mutation: the REACTIVE path in chatCore.ts:~3912 still flips the account to expired after the upstream confirms the auth failure, which is the correct moment (by then the rotation map at tokenRefresh.ts:~1541 and the DB-staleness check have already had their chance to recover). Marked the block "SOURCE OF TRUTH — do not flip the proactive path back. Ask the operator first." with the regression history (ad3d4b6 -> 0c94c39 -> this revert) so a future review does not re-introduce the regression on autopilot. oauth/kiro — centralize social-flow constants in KIRO_CONFIG social-authorize/route.ts and social-exchange/route.ts duplicated the AWS Kiro device-auth URL and the "kiro-cli" public client identifier. Move both to KIRO_CONFIG (alongside the existing AWS SSO OIDC + social auth fields) and add an env override on socialClientId so operators can pin a custom value via KIRO_OAUTH_CLIENT_ID. New KIRO_CONFIG fields: socialClientId (env-overridable), socialDeviceAuthorizeUrl, socialDevicePollUrl. tests/unit/oauth-kiro.test.ts locks the contract: routes must import KIRO_CONFIG and must not inline the AWS URL or "kiro-cli" literal. dashboard/providers — memoize ProviderCard lookup constants Move KIND_LABEL and DOT_COLORS into useMemo so they don't recreate on every render. Functional parity, slightly cheaper re-renders. test(authz) — lockdown Next.js 16 proxy.ts contract New tests/unit/authz/proxy-contract.test.ts asserts the file lives at src/proxy.ts (not src/middleware.ts), exports the proxy function, delegates to runAuthzPipeline with enforce:true, and the matcher covers every prefix mounted under /api so unauthenticated requests cannot bypass the centralized tier checks. version — roll back from 3.8.5 to 3.8.4 CHANGELOG.md consolidates the unreleased 3.8.5 entries into the 3.8.4 section. Mirror that in package.json, package-lock.json and docs/reference/openapi.yaml. .source/* picked up the regenerated fumadocs section ordering. docs — env contract additions Add KIRO_OAUTH_CLIENT_ID and OMNIROUTE_PROXY_FETCH_DEBUG to .env.example and docs/reference/ENVIRONMENT.md so the env-doc-sync check stays green. * fix(oauth/providers): dedupe duplicate trae import and entry src/lib/oauth/providers/index.ts had `import { trae } from "./trae"` on both line 24 and line 28, and listed `trae,` twice in the PROVIDERS map (once next to cursor, again at the end after `"devin-cli": windsurf`). Webpack's flight loader rejects the duplicate identifier and fails the production build with: Module parse failed: Identifier 'trae' has already been declared Introduced by 0e56c5f (chore(security): hardening pass + Trae IDE provider). The CI build job for release/v3.8.4 has been red since that commit on this account because of this — unrelated to the Codex multi-account fix in 448b65a. Just removing the duplicate import and entry; typecheck:core stays clean and eslint reports no issues. * fix(v3.8.4-followup): 5 bug fixes from triage of 79 open issues (diegosouzapw#2753) Integrated into release/v3.8.4 * feat(batch-fixes): batch processing recovery, clean UI, docker compose base profile, test parallelism (diegosouzapw#2761) Integrated batch fixes, UI enhancements, and test parallelism into release/v3.8.4 * fix(antigravity): stabilize model detection, OAuth, and token refresh (diegosouzapw#2757) Stabilized Antigravity model detection, OAuth parameters, token refresh, and PKCE transition * Broaden routing, provider, and dashboard capabilities (diegosouzapw#2750) Broaden routing, provider, and dashboard capabilities * fix: resolve headers private slot errors, typecheck issues, and fix unit tests (diegosouzapw#2763) Integrated into release/v3.8.4 * docs(changelog): credit JxnLexn and hartmark, sync fixes to v3.8.4 * chore(husky): disable pre-commit checks --------- Co-authored-by: Ronaldo Davi <ronaldodavi@gmail.com> Co-authored-by: Automation <automation@omniroute> Co-authored-by: M.M <mr.maatoug@gmail.com> Co-authored-by: Hernan Javier Ardila Sanchez <herjarsa@users.noreply.github.com> Co-authored-by: Ahmet Çetinkaya <ahmet-cetinkaya@users.noreply.github.com> Co-authored-by: Benson K B <benzntech@users.noreply.github.com> Co-authored-by: terence71-glitch <terence71-glitch@users.noreply.github.com> Co-authored-by: Hernan Javier Ardila Sanchez <hjasgr@gmail.com> Co-authored-by: Benson K B <bensonkbmca@gmail.com> Co-authored-by: Paijo <14921983+oyi77@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: df4p <38404+df4p@users.noreply.github.com> Co-authored-by: Ahmet Çetinkaya <ahmetcetinkaya@tutamail.com> Co-authored-by: terence71-glitch <mcdowellterence71@gmail.com> Co-authored-by: Container <78986709+disonjer@users.noreply.github.com> Co-authored-by: Thanet S. <cho.112543@gmail.com> Co-authored-by: janeza2 <49841619+janeza2@users.noreply.github.com> Co-authored-by: Jan Leon <Jan.gaschler@gmail.com>
…ory (diegosouzapw#2765) Bumps the npm_and_yarn group with 1 update in the /electron directory: [tmp](https://github.com/raszi/node-tmp). Updates `tmp` from 0.2.5 to 0.2.6 - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.5...v0.2.6) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.6 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…zapw#2767) * fix(i18n): restore missing UI translations and sync locales * fix(test): adjust security-hardening integration test for compliance split * fix(test): resolve other integration test failures (chat-pipeline, combo-routing, perf-regression)
…apw#2772) Integrated into release/v3.8.5
Integrated into release/v3.8.5
Update changelog entries, API reference version, package metadata, and localized LLM documentation for the 3.8.5 release. Refresh generated docs source mappings and architecture counts for current executors and OAuth providers.
… SHA-256 cache-key rationale (diegosouzapw#2894) Two security-scanning findings on release/v3.8.6: - Secret-scanning alert 7 (google_api_key): the windsurf login-fix design spec embedded the literal public Firebase Web API key on two lines. Firebase Web API keys are non-sensitive by design (they identify the project; access is gated by Firebase Security Rules + key restrictions), but the literal trips secret scanning. Redacted to a placeholder; the embedded default still goes through resolvePublicCred per rule #11. - Code-scanning alert 261 (js/insufficient-password-hash): tokenCacheKey() uses SHA-256 to derive an in-memory cache key from the session token, not for password-at-rest storage. Added a comment documenting why CWE-916 KDFs do not apply (false positive).
… pack-artifact) (diegosouzapw#2895) * fix(ci): resolve release/v3.8.6 gate failures (docs-sync, any-budget, pack-artifact) Three CI gates failed on release/v3.8.6 (run 26630300877): - docs-sync: CHANGELOG had a spurious "## [3.8.6-patch]" section above "## [3.8.6]", so the latest release no longer matched package.json (3.8.6) and the 41 i18n CHANGELOG mirrors were flagged as missing that section. Fold the lone diegosouzapw#2752 entry into [3.8.6] and drop the patch heading. - any-budget:t11: open-sse/handlers/chatCore.ts regressed to 1 explicit `any` (budget 0). Type the persist callback arg as Record<string, unknown>, which matches runWithOnPersist's RefreshPersistFn contract exactly. - pack-artifact: open-sse/utils/setupPolyfill.ts ships via package.json "files" (bin/omniroute.mjs imports it at startup) but was missing from the pack policy allowlist. Allow it and add a regression test. * fix(security): redact public Firebase Web key from windsurf spec Redact the literal public Firebase Web API key (secret-scanning #7) to a placeholder, mirroring the redaction on release/v3.8.6 (PR diegosouzapw#2894) and the windsurf fix branch. Non-sensitive public Web key; trips secret scanning.
…dictive TTFT) (diegosouzapw#2868) * feat(combo): implement zero-latency combo optimizations (hedging, proactive compression, predictive TTFT) * fix(combo): fix predictive TTFT skip logic and unhandled promise rejections --------- Co-authored-by: Automation <automation@omniroute>
…tion and validation schemas
…oncurrency issues
…discovery tool New providers: - huggingchat: free LLM chat via huggingface.co/chat (no subscription) - phind: free dev-focused AI chat via phind.com/api/agent - poe-web: multi-model chat via poe.com GraphQL (p-b cookie) - venice-web: privacy-focused AI chat via venice.ai (session cookie) - v0-vercel-web: Vercel v0 code gen via v0.dev (session cookie) - kimi-web: Moonshot Kimi chat via kimi.moonshot.cn (session cookie) - doubao-web: ByteDance Doubao chat via doubao.com (session cookie) Additional: - Research catalog: docs/research/UNLIMITED_LLM_ACCESS.md - Discovery tool design + stub: src/lib/discovery/ + migration 073 - Unit tests: 33 tests for all 7 providers - Shared helpers consolidated in error.ts (slop cleanup) - All registered in WEB_COOKIE_PROVIDERS + providerRegistry + webSessionCredentials Closes diegosouzapw#2885
… CLI token import (diegosouzapw#2899) Add a standalone OAuth provider `agy` (Antigravity CLI) next to gemini-cli/antigravity. It reuses the antigravity inference backend (identical Google client_id + daily-cloudcode-pa.googleapis.com endpoint, executor and token-refresh) but ships its own model catalog — including the Claude models the backend exposes (claude-opus-4-6-thinking, claude-sonnet-4-6) — its own account pool, and four ways to connect: - token-file import (paste/upload the agy oauth token JSON) - auto-detect a local CLI login (~/.gemini/antigravity-cli/antigravity-oauth-token) - browser OAuth (via the shared OAuthModal Google loopback flow) - bulk / ZIP import New routes: POST /api/providers/agy-auth/{import,import-bulk,zip-extract,apply-local}. Catalog pinned from the live :fetchAvailableModels endpoint. Docs (openapi.yaml, ENVIRONMENT.md, .env.example, CHANGELOG) updated; new unit tests for registration, the token parser, and route auth-hardening.
…gosouzapw#2896) Redact the literal public Firebase Web API key (secret-scanning #7) to a placeholder. Firebase Web API keys are non-sensitive by design but the literal trips GitHub secret scanning. Mirrors the redaction landed on release/v3.8.6 (PR diegosouzapw#2894). Embedded default still flows through resolvePublicCred (rule #11).
* fix(security): mitigate Socket.dev supply-chain findings + secrets opt-in + minimal build profile (diegosouzapw#2863) Two real security gaps closed and four cosmetic Socket.dev fingerprints removed. See docs/security/SOCKET_DEV_FINDINGS.md for the per-finding maintainer attestation. Real bugs fixed: - cloudSync: HMAC verification of `X-Cloud-Sig` + opt-in `OMNIROUTE_CLOUD_SYNC_SECRETS=true` before overwriting `accessToken` / `refreshToken` / `providerSpecificData` from a remote response. Closes the silent-credential-swap surface (a misconfigured or hostile CLOUD_URL could previously replace local tokens unverified). - Zed import: split into 2-step `/discover` + `/import` flow. `/import` now requires `confirmedAccounts: [{ service, account, fingerprint }]` and re-reads the keychain server-side to filter by fingerprint, so a tampered discover response cannot trick the endpoint into saving an unrelated token. Cosmetic Socket.dev mitigations: - runElevatedPowerShell writes the elevated payload to a per-call temp `.ps1` file (mode 0o600) and references it via `-File`. Removes the textbook `-EncodedCommand <base64utf16le>` pattern flagged as malware by Socket's AI classifier. - Maintainer attestation `SECURITY-AUDITOR-NOTE:` blocks added at every flagged call site pointing to `docs/security/SOCKET_DEV_FINDINGS.md`. Build-time hardening: - `OMNIROUTE_BUILD_PROFILE=minimal` (`npm run build:secure`) physically removes the four sensitive modules from the standalone bundle via webpack `NormalModuleReplacementPlugin`. Stubs throw `FeatureDisabledError` at runtime. Intended for the `omniroute-secure` artifact. Tests: - 24 new unit tests in `tests/unit/security/` covering the wrapper builder, HMAC verification (4 cases), credential fingerprint determinism (5 cases), confirmedAccounts validation + fingerprint filtering (6 cases), and the minimal-build stubs (5 cases). Docs: - New `docs/security/SOCKET_DEV_FINDINGS.md` — per-finding attestation. - New `socket.yml` — Socket.dev v2 config pointing at the attestation. - Updated `SECURITY.md` — supply-chain scanner section. - Updated `.env.example` — three new env vars documented. Backwards compatibility: - Cloud sync token overwrite is OFF by default. Users who relied on it must set `OMNIROUTE_CLOUD_SYNC_SECRETS=true`. Breaking change documented in CHANGELOG. - Zed import 2-step is the new default; legacy 1-step preserved behind `OMNIROUTE_ZED_IMPORT_LEGACY_ONE_STEP=true` and will be removed in v3.9. Closes diegosouzapw#2863 * feat: implement automated skill workflows and update system configuration and validation schemas * test: eliminate dynamic cast warnings in cloud-sync unit test * test: isolate services-branch-hardening database directory to avoid concurrency issues
Update the generated Fumadocs browser collection mapping to keep documentation imports in sync with the current docs structure.
Refresh the generated Fumadocs browser collection mapping so the docs site can resolve the current documentation files correctly.
Code Review SummaryStatus: 7 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
WARNING
Other Observations (not in diff)
Files Reviewed (10 files)
Note: This plugin system is a significant architectural addition that introduces code execution from external sources. The security surface area should be carefully reviewed before v4.0.0 integration. Reviewed by nemotron-3-super-120b-a12b-20230311:free · 3,525,065 tokens |
Integrated into release/v3.8.6
Integrated into release/v3.8.6
- Path traversal guard: validate entryPoint stays within plugin dir - install() now handles direct plugin directories (not just parent dirs) - Non-null assertion replaced with explicit null check - require efficiency: allowedModules map moved outside function - Source wrapper: add newlines to prevent trailing comment issues - Config validation: validate values against configSchema on save - Dynamic import comment: clarify Node.js caching behavior Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com>
Addresses all remaining code review feedback: 1. **Loader rewrite**: Replaced Node.js vm module with child_process.fork() for proper process-level isolation. Complies with Rule 3 (no eval). Each plugin runs in a separate Node.js process with IPC communication. 2. **Auth on all routes**: Added requireManagementAuth to all 6 plugin API route files (list, install, scan, details, activate, deactivate, config). 3. **Env filtering**: Only safe env vars passed to plugin processes unless "env" permission is granted. Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com>
loader.ts:
- Fix IPC: use process.send()/process.on("message") instead of worker_threads.parentPort
- Fix ESM: write host script as .mjs (not .js) to force ESM execution
- Add timeout: 10s default on callHook() with Promise.race
- Add SIGKILL escalation: SIGTERM first, then SIGKILL after 3s grace
- Fix env filtering: use allowlist (safeKeys) instead of passing all env vars
- Clear timeout on successful IPC response (no timer leak)
manager.ts:
- Fix path traversal: use fs.realpath() instead of startsWith()
- Fix imports: use registerHook/unregisterHooks from hooks.ts
- Register hooks individually via registerHook(event, name, handler)
hooks.ts:
- Copied from feat/plugin-custom-hooks (canonical registry)
Phase 1 scaffold for automated provider discovery: - DiscoveryConfig, DiscoveryResult types - probeEndpoint() for URL availability checking - scanProvider() stub (Phase 2 will implement real scanning) - getDiscoveryResults() stub - Default config: disabled (opt-in)
- index.ts: replace console.log/error with pino structured logging - hooks.ts: remove redundant .sort() in emitHookBlocking/runOnResponse (already sorted on registration) - manager.ts: add readFile import
- scanner: 9 tests (discovery, hidden dirs, validation, entry point, multiple) - loader: 5 tests (type contracts, Plugin/PluginContext/PluginResult interfaces) - manager: 6 tests (singleton, lifecycle methods, error on unknown) - Total: 20 tests, all passing
Contributor
Author
|
Superseded by #2912 (feat/plugin-system) — backend core consolidated and updated to target release/v3.8.6 with all security/ESM fixes applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the backend foundation for a WordPress-style plugin system (closes #2060).
What's included:
pluginstable migration + CRUD module (src/lib/db/plugins.ts)plugin.jsonschema (src/lib/plugins/manifest.ts)~/.omniroute/plugins/(src/lib/plugins/scanner.ts)src/lib/plugins/loader.ts)src/lib/plugins/manager.ts)src/app/api/plugins/)open-sse/mcp-server/tools/pluginTools.ts)onRequest+onErrorhooks wired intochatCore.tsWhat's NOT included (next PR):
/dashboard/plugins)Test plan
npm run typecheck:core— passesnpm run lint— passes🤖 Generated with OpenClaude