fix(gitlawb): add specialty validators for connection test — bypass /models probe

[oyi77]

Problem

The GitLawB OpenGateway API (xiaomi-mimo compatible) returns 404 on connection test for both gitlawb and gitlawb-gmi providers. This causes the dashboard to show persistent "error" status for these connections even with valid API keys.

Additionally, the models list endpoint showed a misleading "API unavailable — using local catalog" warning for gitlawb providers, even though all registered models are fully functional via POST /chat/completions.

Root Cause

Connection test

The generic validateOpenAILikeProvider validation flow works in two stages:

1. Stage 1 — GET /models: Hits {baseUrl}/models (e.g., https://opengateway.gitlawb.com/v1/xiaomi-mimo/models) — returns 404 because the OpenGateway API does not expose a models endpoint at that provider-path.
2. Stage 2 — Fallback POST /chat/completions: On non-401/403 failure, falls back to a chat completions probe. This also fails because the generic fallback doesn't handle the xiaomi-mimo-compatible auth model correctly.

Result: validateProviderApiKey returns "Provider validation endpoint not supported", and the connection is permanently marked as "error" with a 404 diagnosis.

Models list

Since gitlawb and gitlawb-gmi are not in PROVIDER_MODELS_CONFIG, the models route fell through to the generic fallback which returns static catalog models with the warning "API unavailable — using local catalog". This warning is misleading — the models are fully functional.

Changes

1. Connection test fix (src/lib/providers/validation.ts)

Add specialty validators for both gitlawb and gitlawb-gmi in the SPECIALTY_VALIDATORS map. These mirror the existing xiaomi-mimo validator — since all three use the same underlying API format:

• Skip the GET /models probe entirely
• Validate directly via POST /chat/completions with a minimal test message
• 401/403 → invalid API key
• Any other response (200, 400, 422, 429) → auth passed

Provider	Default baseUrl	Test model
gitlawb	https://opengateway.gitlawb.com/v1/xiaomi-mimo	mimo-v2.5-pro
gitlawb-gmi	https://opengateway.gitlawb.com/v1/gmi-cloud	XiaomiMiMo/MiMo-V2.5-Pro

2. Models list fix (src/app/api/providers/[id]/models/route.ts)

Add gitlawb and gitlawb-gmi as static model providers (same pattern as reka and qwen OAuth). Models are served from the provider registry without the misleading "API unavailable" warning, since all registered models are functional via the chat completions endpoint.

3. Unit tests (tests/unit/provider-validation-specialty.test.ts)

Add 12 new tests covering both providers:

Test	gitlawb	gitlawb-gmi
Valid API key (200)	✅	✅
Auth-passing responses (400)	✅	✅
Auth-passing responses (422)	✅	✅
Auth-passing responses (429)	✅	✅
Invalid API key (401)	✅	✅
Invalid API key (403)	✅	✅
Network failure	✅	✅
Custom baseUrl override	✅	✅

Testing

Connection test

1. Add a GitLawB provider connection with a valid API key → connection test returns "active"
2. Add a GitLawB provider connection with an invalid API key → connection test returns "Invalid API key"
3. Add a GitLawB provider connection with no API key (free tier) → connection test returns "active"
4. Verify existing xiaomi-mimo connections still pass — new validators follow the exact same pattern

Unit tests

# tests 80
# pass 80
# fail 0

Models list

• Navigate to gitlawb or gitlawb-gmi provider settings → models appear without warning
• All registered models returned from local catalog

Related

• GitLawB provider was initially added in feat(provider): add Gitlawb Opengateway provider #2314 (commit b83d1a0fc)
• Follow-up fixes in PR fix(providers): restore 20 missing upstream providers + add icons for 28 gap providers #2476

[kilo-code-bot]

Kilo Code Review could not run — your account is out of credits.

Add credits or switch to a free model to enable reviews on this change.

[gemini-code-assist]

Code Review

This pull request adds validation support for the gitlawb and gitlawb-gmi providers in src/lib/providers/validation.ts by bypassing the /models probe in favor of a /chat/completions request. The reviewer recommended refactoring the two new validators to eliminate code duplication by extracting a shared helper function. Additionally, the reviewer noted that unit tests must be added to cover these new validators, as required by Rule 9 of the Repository Style Guide when modifying production code.

[gemini-code-assist]

Code Duplication

The specialty validators for gitlawb and gitlawb-gmi are virtually identical, differing only in their default base URLs and model IDs. This duplication can be avoided by extracting a shared validation helper function using an inline IIFE. This improves maintainability and prevents future logic drift between the two providers.

    // Gitlawb Opengateway — Xiaomi MiMo compatible, same /models endpoint limitation.
    // Bypass /models probe in favor of chat/completions, matching xiaomi-mimo's pattern.
    ...(() => {
      const validate = async ({ apiKey, providerSpecificData, defaultBaseUrl, model }: any) => {
        try {
          const baseUrl = normalizeBaseUrl(providerSpecificData?.baseUrl || defaultBaseUrl);
          const chatUrl = `${baseUrl.replace(/\/chat\/completions$/, "")}/chat/completions`;
          const res = await validationWrite(
            chatUrl,
            {
              method: "POST",
              headers: buildBearerHeaders(apiKey, providerSpecificData),
              body: JSON.stringify({
                model,
                messages: [{ role: "user", content: "test" }],
                max_tokens: 1,
              }),
            },
            isLocal
          );
          if (res.status === 401 || res.status === 403) {
            return { valid: false, error: "Invalid API key" };
          }
          return { valid: true, error: null };
        } catch (error: any) {
          return toValidationErrorResult(error);
        }
      };
      return {
        gitlawb: (args: any) =>
          validate({
            ...args,
            defaultBaseUrl: "https://opengateway.gitlawb.com/v1/xiaomi-mimo",
            model: "mimo-v2.5-pro",
          }),
        "gitlawb-gmi": (args: any) =>
          validate({
            ...args,
            defaultBaseUrl: "https://opengateway.gitlawb.com/v1/gmi-cloud",
            model: "XiaomiMiMo/MiMo-V2.5-Pro",
          }),
      };
    })(),

[gemini-code-assist]

Missing Tests for Production Code Change

According to the Repository Style Guide (Rule 9), changing production code under src/ requires including tests. Please ensure that appropriate unit tests are added in the tests/ directory to cover these new specialty validators for gitlawb and gitlawb-gmi.

References

1. Rule 9: Always include tests when changing production code (src/, open-sse/, electron/, bin/). ^(link)