Repository navigation
fix(streaming): mask credentials in streaming responses under the same opt-in - #16786
Merged
diegosouzapw merged 1 commit intoOct 16, 2026
Conversation
maxmad64bis
force-pushed
the
fix/credential-masker-absent-streaming
branch
from
October 15, 2026 21:24
2f3276a to
e547d0f
Compare
maxmad64bis
marked this pull request as ready for review
October 15, 2026 21:51
diegosouzapw
pushed a commit
that referenced
this pull request
Oct 16, 2026
Local board on origin/release/v3.8.52 (ad37e8f) in `.claude/worktrees/maxmad-wave2`, together with #16759, #16760, #16769, #16773, #16786, and #16793. The combined tree passed `check-file-size` and `check-changelog-integrity`. The health matrix leaves idle models out of the default payload and still counts them in `omittedIdleModelCount`. `includeIdleModels=true` brings the lines back. Focused file: `provider-health-matrix.test.ts`.⚠️ base-red inherited: #15306 Thank you @maxmad64bis.
diegosouzapw
merged commit Oct 16, 2026
d8e3130
into
diegosouzapw:release/v3.8.52
27 of 42 checks passed
9 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the opt-in is on, non-streaming responses mask secrets while streaming responses pass them through in clear text, because the streaming pipeline has no credential step. This change pipes streamed chunks through the same credential check when the existing opt-in is on, so keys and connection strings arrive masked on both paths and bytes stay untouched when it's off or opted out.
Related Issues
Target Branch
release/v3.8.xbranch (the highest openrelease/v*), notmainv4-featurelabel for the v4 channelValidation
npm run lintTests Added Or Updated
tests/unit/streaming-credential-transform.test.ts— covers masking on content and tool arguments, plus image data URLs and split secretstests/unit/chatcore-streaming-pipeline.test.ts— covers pipeline order and the gate staying off by default, off, and under opt-outtests/unit/sseTextTransform.test.ts— covers routing tool arguments to the processor when the new flag is onCoverage Notes
src/lib/streamingCredentialTransform.ts— covered bytests/unit/streaming-credential-transform.test.tsopen-sse/handlers/chatCore/streamingPipeline.ts— covered bytests/unit/chatcore-streaming-pipeline.test.tsopen-sse/handlers/chatCore/streamingTail.ts— covered by the gate tests intests/unit/streaming-credential-transform.test.tssrc/lib/sseTextTransform.ts— covered bytests/unit/sseTextTransform.test.tsReviewer Notes