Repository navigation
fix(mcp): dynamic skill tools run as authenticated key principal - #16760
Merged
diegosouzapw merged 1 commit intoOct 16, 2026
Conversation
maxmad64bis
force-pushed
the
fix/dynamic-skill-sessionid-owner-spoof
branch
from
October 15, 2026 19:42
59eb3a8 to
bdd8388
Compare
maxmad64bis
marked this pull request as ready for review
October 15, 2026 20:00
diegosouzapw
merged commit Oct 16, 2026
96ef37f
into
diegosouzapw:release/v3.8.52
45 of 59 checks passed
diegosouzapw
pushed a commit
that referenced
this pull request
Oct 16, 2026
Local board on origin/release/v3.8.52 (ad37e8f) in `.claude/worktrees/maxmad-wave2`, together with #16759, #16760, #16769, #16773, #16786, and #16793. The combined tree passed `check-file-size` and `check-changelog-integrity`. The health matrix leaves idle models out of the default payload and still counts them in `omittedIdleModelCount`. `includeIdleModels=true` brings the lines back. Focused file: `provider-health-matrix.test.ts`.⚠️ base-red inherited: #15306 Thank you @maxmad64bis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A dynamic skill call ran as whatever session id the client sent, so a keyless client could run a skill under another tenant's identity. The handler now runs each dynamic skill tool as the authenticated key principal, the same rule the static skill tools and memory tools already use, and a keyless call still runs as
mcp.Related Issues
Target Branch
release/v3.8.xbranch (the highest openrelease/v*), notmainv4-featurelabel for the v4 channelValidation
npm run lintTests Added Or Updated
tests/unit/mcp-dynamic-skill-owner.test.ts— covers the three gate cases: a key with another tenant's session id, a keyless call with a session id, and a second key with the first tenant's session id.Coverage Notes
open-sse/mcp-server/server.ts— covered bytests/unit/mcp-dynamic-skill-owner.test.ts, andtests/unit/mcp-public-error-boundaries.test.tsstill runs green through the same handler.tests/unit/mcp-dynamic-skill-owner.test.ts— new test for the owner rule itself.fix(mcp)changelog fragment — no code to cover.Reviewer Notes
mcpeven when it sends a session id (before, it ran as that session id); calls with a key run as before.