Repository navigation
fix(skills): repoint remaining omniroute-cli skill links (#15665) - #16109
Merged
Merged
Conversation
The omniroute-* skill dirs were renamed to omni-*/cli-* long ago, but several skills still linked to the old raw URLs, which now 404 for agents following them. #15676 fixed the capability table in omni-auth; this repoints the rest: - omniroute/SKILL.md (entry point) -> omni-auth (its content was migrated there; 12 "entry-point SKILL" links across omni-* skills) - omniroute-cli / omniroute-cli-admin -> cli-serve (both migrated there); the self-reference inside cli-serve now points at its own sections - omniroute-cli-providers -> cli-providers, omniroute-cli-eval -> cli-eval - omniroute-cli-cloud -> cli-backup-sync: the generator assigns the whole 'omniroute cloud' command group (cloud-agent tasks) to that skill (src/lib/agentSkills/cliRegistryParser.ts), and it is the only skill that documents those subcommands; the row labels now say 'omniroute cloud' Adds a regression test to skillManifestsLint: every skills/<dir>/SKILL.md reference inside a skill (outside HTML comments) must resolve. Co-authored-by: afonsoft <11299396+afonsoft@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15665
What
#15676 (thanks @Poid-ZA) fixed the "Capability skills" table in
omni-authand the routing link incli-providers. This PR fixes every remaining link to a deletedskills/omniroute*/SKILL.mddirectory (all 404 on raw GitHub):omniroute/SKILL.md(12 "entry-point SKILL" links in omni-inference/combos-routing/resilience/mcp/agents-a2a/compression)omni-auth<!-- Migrated from skills/omniroute/SKILL.md -->in omni-auth; its description says "Start here"omniroute-cli,omniroute-cli-admincli-serveomniroute-cli-providerscli-providersomniroute-cli-evalcli-evalomniroute-cli-cloud(cloud agents)cli-backup-synccli-backup-syncCloud agents decision. No
cli-*cloud*skill exists. The skill generator assigns the wholeomniroute cloudcommand group tocli-backup-sync(src/lib/agentSkills/cliRegistryParser.ts:cloud: "cli-backup-sync"). That command group (bin/cli/commands/cloud.mjs) is the cloud-agent task CLI, hitting/api/v1/agents/tasks.cli-backup-syncis the only skill that documentsomniroute cloud create/list/status/approve/message/sources/agents/auth, so the link goes there. The row labels now sayomniroute cloud …so readers aren't sent to a "backup" skill without explanation. (Splittingcloudinto its own skill would be a generator change and is out of scope here.)Remap groundwork came from #16016 (thanks @afonsoft), credited as co-author. I also confirmed the cloud-agent target and added the entry-point links that #16016 didn't cover.
Every edited line is inside a
<!-- skill:custom-start/end -->block, so the generator keeps it on--apply. Tables were aligned by hand becauseskills/*/SKILL.mdis in.prettierignore.Regression test
tests/unit/docs/skillManifestsLint.test.tsgets a new check: everyskills/<dir>/SKILL.mdreference inside a skill (HTML comments excluded, since migration-provenance markers aren't links) must resolve to an existing skill dir.dangling skill links: …)Checks
node --import tsx/esm --test tests/unit/docs/skillManifestsLint.test.ts: 4/4 passcheck:docs-sync,check:docs-frontmatter,check:env-doc-sync,check:deprecated-versions,check:doc-links,check:fabricated-docs: all passcheck:docs-counts: fails, inherited. The 7 strict drifts are provider count 371 (live) vs 370 inPROVIDER_REFERENCE.mdand the hero/tier SVGs, unrelated to skills.check:agent-skills-sync: exit 2, inherited. The base tip reports the exact same 20-skill "would regenerate" list.