Repository navigation
fix(combo): type the custom-model row in the auto pool check - #15461
Merged
diegosouzapw merged 2 commits intoOct 6, 2026
Merged
Conversation
typecheck:noimplicit:core failed on the callback in expandAutoComboCandidatePool. getCustomModels returns JSON.parse, so the row has no inferred type. The callback only reads id, and a missing id is skipped. The annotation matches that read. Related to diegosouzapw#15437. Signed-off-by: Minxi Hou <houminxi@gmail.com>
The type annotation PR needs its own changelog fragment so release aggregation picks it up. Signed-off-by: Minxi Hou <houminxi@gmail.com>
7 of 8 tasks
diegosouzapw
merged commit Oct 6, 2026
3361111
into
diegosouzapw:release/v3.8.52
42 of 51 checks passed
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run typecheck:noimplicit:corefails onrelease/v3.8.52atopen-sse/services/combo/autoStrategy.ts. The callback incustomModels.somehas an implicitanybecausegetCustomModelsreturnsJSON.parse.id. A missingidis skipped by the existingm.id &&check. The annotation is{ id?: string }, which matches that read. It does not change runtime behavior.Validation
npm run typecheck:noimplicit:coreexits 0 after the changereview-default: 0 CONFIRMED. The surviving UNCERTAIN notes disagree with each other (one saysidis required, one says the row might not be an object).getCustomModelsatsrc/lib/db/models.tsreturnsJSON.parseor[], soidis not a required typed field. The receipt line-count note is an excerpt check, not a product defect.Tests Added Or Updated
Coverage Notes
Reviewer Notes
addCustomModelstores objects withid: modelId. The read path does not re-validate that shape, which is existing behavior. This change does not parse or trust a new field.