Repository navigation
fix(dashboard): report headers-wait and client aborts outside transport failures - #15248
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Conversation
maxmad64bis
force-pushed
the
fix/proxy-health-slow-abandoned
branch
from
September 30, 2026 23:58
1266384 to
33b32ef
Compare
maxmad64bis
marked this pull request as ready for review
October 1, 2026 18:31
maxmad64bis
force-pushed
the
fix/proxy-health-slow-abandoned
branch
from
October 2, 2026 15:08
33b32ef to
a28fa0b
Compare
4 of 5 tasks
maxmad64bis
marked this pull request as draft
October 3, 2026 01:16
maxmad64bis
force-pushed
the
fix/proxy-health-slow-abandoned
branch
from
October 3, 2026 01:17
a28fa0b to
405b9e9
Compare
maxmad64bis
marked this pull request as ready for review
October 3, 2026 01:41
This was referenced Oct 3, 2026
diegosouzapw
merged commit Oct 6, 2026
3156744
into
diegosouzapw:release/v3.8.52
118 of 166 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slow proxies waiting on response headers showed the same transport rate as dead proxies: the health aggregation counted every failed row without an upstream status as a transport failure, including deliberate abandonments after the headers-wait threshold and client-side aborts. Those two categories are now excluded from transport failures and reported as separate counters (
slowAbandoned,clientAborted), so the transport rate reflects genuine transport health. The new predicates are NULL-safe, so legacy rows without a marker, connection-test rows, and rows with an upstream status keep their previous path.Related Issues
Validation
npm run lint— ESLint on the touched files is clean; the full run is red on the base (🔴 Release branch not green: release/v3.8.52 #15306).Tests Added Or Updated
tests/unit/db-proxies-ventilated.test.ts: extended the seed helper withattempt_issue/errorcolumns (defaulting to null, so older cases are unchanged); 6 new cases — headers-wait abandonment, abandoned client abort, served client abort, abandoned connection error, long-ceiling timeout, and a mixed transport-rate check.tests/unit/db-proxies-crud.test.ts: the exact-match suite now expectsslowAbandonedandclientAbortedat zero.Coverage Notes
src/lib/db/proxies.ts: newslow_abandoned/client_abortedaggregates plus the narrowedtransport_failurespredicate, all NULL-safe — covered by the 6 new ventilated cases plus the exact-match case (fail without the fix, pass with it).src/app/(dashboard)/dashboard/settings/components/ProxyHealthCell.tsx: additive read of the two new counters, defaulting to zero.src/app/(dashboard)/dashboard/settings/components/proxyRegistryConstants.ts:HealthInfoextended withslowAbandoned/clientAborted.src/i18n/messages(en + all locales): three new keys (slowAbandoned,clientAborted,slowAbandonedHint), no missing values.Reviewer Notes
src/i18n/messagesfiles carry the 3 new flat keys, zero__MISSING__;vi.jsonis a pure 3-line addition. Text matching is used because the journal keeps only the message (theOPENCODE_HEADERS_WAIT_TIMEOUTcode is not persisted on the row).