fix(release): run the i18n contract gates in the merge-train - #14437
Merged
Merged
Conversation
The train validated typecheck, file-size/complexity and changelog integrity only, so combined trees that add en.json keys without catalogs or edit docs without mirrors reached release/v3.8.51 three times in 48 h (#13670, 1b2349d, 7f1b4a5) while each PR's own CI was red on those gates. i18n:check-keys, i18n:check-keys:cli, i18n:check-ratio and the docs drift gate now run with the static gates.
5 tasks done
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The local merge-train (
scripts/release/merge-train.sh, merge-gates.md §7) validated onlytypecheck:core, file-size, both complexity gates and changelog integrity on the combined tree, then merged with--admin. That is how three PRs that addeden.jsonkeys without catalogs (#13670,1b2349de,7f1b4a5e) and dozens that edited docs without mirrors reachedrelease/v3.8.51in 48 h while their own CI was red on the i18n gates — each landing re-opened the debt the i18n completion plan had just closed (#13996, #14078, #14106, #14166, #14357).This adds the four deterministic i18n contract gates to
STATIC_GATES(a few seconds each; the drift gate ~30 s over 9,880 mirrors):npm run i18n:check-keys— everyen.jsonkey present in all 65 dashboard catalogsnpm run i18n:check-keys:clinpm run i18n:check-ratio— real-translation ratio within baselinenode scripts/i18n/check-translation-drift.mjs— docs mirrors up to date (stale-after-interruption is a warning, not a failure)A red ejects the offending PR like any other gate; the fix stays in that PR (
npm run i18n:translate-new-keysfor UI keys,npm run i18n:run -- --files=<doc>for docs, both documented indocs/guides/I18N.md). The matching line in.agents/skills/_shared/merge-gates.md§7 step 3 is updated in the skills repo.Policy note for the operator: this extends the owner-approved train gate list (merge-gates.md §7, 2026-07-09 / 2026-07-18); it changes what the train refuses, not what CI runs.
Validation
bash -n scripts/release/merge-train.shi18n:check-keysOK,i18n:check-keys:cliOK,i18n:check-ratioOK, drift: FAIL ondocs/reference/ENVIRONMENT.md(the tip's own debt, being refreshed in a sibling PR) — i.e. the gate would have caught exactly what it is meant to catch