Skip to content

fix(ci): propagate exhausted npm install failures - #14369

Merged
diegosouzapw merged 1 commit into
release/v3.8.51from
fix/qg01-npm-ci-exit-20260921
Sep 24, 2026
Merged

diegosouzapw merged 1 commit into
release/v3.8.51from
fix/qg01-npm-ci-exit-20260921

Conversation

@diegosouzapw

Copy link
Copy Markdown
Owner

Problem and change

When all three npm ci attempts fail, the composite action captures the status of
the completed if statement (zero). Downstream jobs then continue without installed
dependencies and the cache-miss path appears successful. Capture the npm exit in
the else branch so the final failed attempt fails the composite.

Validation

  • RED on 06f1df9d775d: the actual Bash action returned 0 for 41,42,43 and 42,42,42.
  • GREEN: 8/8 tests across the new behavioral fixture and existing cache-contract suite.
  • Successful retry and initial success still stop immediately; retry delays remain 20/40s.
  • Focused ESLint, Prettier, diff check and all pre-commit gates passed.

⚠️ base-red inherited: #13866. This PR repairs exit propagation only. Lockfile repair,
build fail-closed, the full quality profile and required verdict rollout are separate
items in the authorized recovery plan. Full release-green is not claimed here.

@diegosouzapw
diegosouzapw marked this pull request as ready for review September 24, 2026 00:42
@diegosouzapw
diegosouzapw merged commit 0fe31c6 into release/v3.8.51 Sep 24, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant