Repository navigation
Conversation
diegosouzapw
added a commit
that referenced
this pull request
Sep 1, 2026
…estFiles (#12263) Gate check:mutation-test-coverage --strict red→verde local (registro dos 2 testes turn-pin no tap.testFiles, drift da mesma classe do #12170). O único check vermelho desta PR (Unit shard 4/4) é o base-red dos próprios testes turn-pin desalinhados pelo #12247 — corrigido pela #12259, mergeada na sequência. Reds circulares: cada PR só está vermelha no item que a outra corrige.
Contributor
Author
Owner
|
Obrigado pelo diagnóstico e fix rápidos, @backryun — o root cause e a direção estavam exatamente certos! 🙏 Enquanto esta PR aguardava, o mesmo alinhamento (loop até |
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…estFiles (diegosouzapw#12263) Gate check:mutation-test-coverage --strict red→verde local (registro dos 2 testes turn-pin no tap.testFiles, drift da mesma classe do diegosouzapw#12170). O único check vermelho desta PR (Unit shard 4/4) é o base-red dos próprios testes turn-pin desalinhados pelo diegosouzapw#12247 — corrigido pela diegosouzapw#12259, mergeada na sequência. Reds circulares: cada PR só está vermelha no item que a outra corrige.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns two stale native Codex turn-pin tests with the provider-level cooldown contract introduced by #12247.
#12247 changed whole-provider cooldowns from “one recorded failure starts cooldown” to the
PROVIDER_PROFILESwindow gate: the provider only enters cooldown afterproviderFailureThresholdfailures withinproviderFailureWindowMs. The production implementation and its new focused tests are correct, but two pre-existing turn-pin tests still recorded only one Antigravity failure before asserting that the whole provider was cooling.That drift currently fails release fast-path shards 3/4 and 4/4, including on #12258:
native-codex-turn-pin-10379.test.tsexpected a provider outage to mask an existing model lockout, but had not actually tripped provider cooldown.native-codex-turn-pin-model-scoped-fallback.test.tsassertedisProviderInCooldown(...) === trueafter only one provider-level failure.Change
Both tests now record
PROVIDER_PROFILES.oauth.providerFailureThresholdfailures for Antigravity before exercising their global-cooldown assertions.This is test-only. No production routing, cooldown, provider, dependency, or bundler behavior changes.
Validation
Before the fix, the exact two files reproduced 2 failures / 15 tests locally, matching CI.
After the fix, the turn-pin files plus #12247's provider cooldown suites pass:
git diff --checkpassedUnblocks the inherited release checks on #12258.