chore(lint): batch 4 of #12146 — shared/components react-hooks violations resolved

[diegosouzapw]

Batch 4 of #12146: the 21 react-hooks/* React Compiler violations in the 11 src/shared/components files are resolved with real refactors — no eslint-disable, and every react-hooks/* suppression entry for these files is removed from config/quality/eslint-suppressions.json (entries for other rules are preserved).

Violations resolved

Rule	Count	Technique
set-state-in-effect	16	(a) prop/state mirrors and modal open/close resets → guarded render-time adjustment (react.dev "You Might Not Need an Effect" prev-tracking); (b) fetch+set effects → async loader moved inside the effect (with cancelled guard where the deps can change) or an effect-local async runner, keeping every setState on the async path; (c) OAuthModal countdown → derived value from deviceCodeExpiresAt + a now tick state; (d) Sidebar localStorage hydration → useSyncExternalStore snapshots + render-time adjustment, persistence consolidated into a single saveToStorage effect
immutability (use-before-declare)	2	PricingModal.loadPricing inlined into its effect; ProxyConfigModal.resetFields hoisted above the effect as a dependency-free useCallback
exhaustive-deps	1	ProxyConfigModal load effect now depends on the stable resetFields and on hoisted translated strings (socks5HiddenError, levelGlobalLabel) instead of the t function identity
preserve-manual-memoization	1	UsageStats.sortedAccounts optional chains destructured into locals so the memo body matches its deps

Per-file

File	Violations	Technique
KiroAuthModal.tsx	set-state-in-effect ×1	close-reset → render adjustment
ModelSelectModal.tsx	set-state-in-effect ×4	3 fetch fns moved into their effects; close-reset → render adjustment
OAuthModal.tsx	set-state-in-effect ×4	countdown derived (state deleted); provider-change/close/open resets → render adjustments with ref invalidation split into ref-only effects; flow start via effect-local async runner (kept the startsInGitlabDuoSetup / if (!startsInPasteMode) startOAuthFlow() shape the #8688 source-pinning test asserts)
PricingModal.tsx	immutability ×1	loadPricing inlined into the effect
ProxyConfigModal.tsx	set-state-in-effect ×1, immutability ×1, exhaustive-deps ×1	open-reset → render adjustment; resetFields hoisted stable; deps on hoisted strings (an unstable t, e.g. the test mock, would loop the load effect)
ReasoningRoutingRules.tsx	set-state-in-effect ×1	effect-local async runner around load()
RequestLoggerDetail.sections.tsx	set-state-in-effect ×1	liveDetail mirror → render adjustment
Sidebar.tsx	set-state-in-effect ×2	hydration via useSyncExternalStore + render adjustment (ref → state); active-section expansion → render adjustment keyed on the old effect deps; one persistence effect (also removes a pre-existing eslint-disable for exhaustive-deps)
UsageStats.tsx	preserve-manual-memoization ×1, set-state-in-effect ×1	memo locals; mount fetch via effect-local runner (redundant sync setLoading(true) dropped — loading starts true)
analytics/useProviderDailyUsage.ts	set-state-in-effect ×1	fetch inlined into the effect with a cancelled guard
compression/ComboCompressionModeSelect.tsx	set-state-in-effect ×1	initialCompressionMode mirror → render adjustment

Validation

• npx eslint --suppressions-location config/quality/eslint-suppressions.json --pass-on-unpruned-suppressions --max-warnings 0 <11 files> → exit 0
• npm run typecheck:core → clean
• Node native sweep (54 matching tests/unit/**/*.test.ts files, env -u OMNIROUTE_API_KEY): 373/373 pass (includes the OAuthModal/gitlab-duo source-pinning tests)
• Vitest sweep (78 matching *.test.tsx files, react18-json-view@0.2.10 installed --no-save): 547/550; the 3 fails are 5s-timeout flakes under parallel load — all 3 files pass isolated (8/8), and one (radar-admin-sidebar) is not a touched file
• Prettier run on every touched file + the suppressions JSON

Refs #12146