Skip to content

fix(tests): await async getExecutor() in gemini-web-image-retirement test #11868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 2 commits into from
Aug 28, 2026
Merged

fix(tests): await async getExecutor() in gemini-web-image-retirement test #11868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65397ba
fix(tests): await async getExecutor() in gemini-web-image-retirement …
hartmark Aug 28, 2026
f7de959
chore(changelog): add fragment for the getExecutor async-drift test fix
hartmark Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixes/11708-gemini-web-retirement-test-async-getexecutor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- **fix(tests):** the new Gemini Web Images retirement test (#11708) called the now-async `getExecutor()` synchronously, throwing `TypeError: getExecutor(...).getProvider is not a function` instead of asserting Gemini Web chat stays available. Awaited to match the R0.3 executor-registry refactor (#11220).
4 changes: 2 additions & 2 deletions tests/unit/gemini-web-image-retirement.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,9 @@ test("Gemini Web image-only parser and handler artifacts are retired", () => {
);
});

test("Gemini Web chat and legitimate Gemini image providers remain available", () => {
test("Gemini Web chat and legitimate Gemini image providers remain available", async () => {
assert.equal(hasSpecializedExecutor("gemini-web"), true);
assert.equal(getExecutor("gemini-web").getProvider(), "gemini-web");
assert.equal((await getExecutor("gemini-web")).getProvider(), "gemini-web");
assert.equal(REGISTRY["gemini-web"]?.executor, "gemini-web");
assert.deepEqual(
REGISTRY["gemini-web"]?.models.map(({ id }) => id),
Expand Down
Loading