fix(tests): await async getExecutor() in gemini-web-image-retirement test - #11868
Merged
diegosouzapw merged 2 commits intoAug 28, 2026
Merged
Conversation
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…test (diegosouzapw#11868) Direct follow-up fixing a bug my own /merge-batch process introduced. Test-only change, focused test passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getExecutor("gemini-web").getProvider()synchronously.getExecutor()became async with the R0.3 executor-registry refactor (feat(backend): lazy-load provider definitions instead of eager-loading all 348 at startup #11220), so this threwTypeError: getExecutor(...).getProvider is not a functioninstead of asserting the intended contract.release/v3.8.51before the fix could be folded into fix(sse): retire Gemini Web image generation #11708's own diff (the merge outran the fix). This is the immediate follow-up.Test plan
node --import tsx/esm --test tests/unit/gemini-web-image-retirement.test.ts— 4/4 passing.