Repository navigation
fix(docs): documented migration count matches the 160 that ship - #11543
Closed
maxmad64bis wants to merge 1 commit into
Closed
maxmad64bis wants to merge 1 commit into
maxmad64bis wants to merge 1 commit into
Conversation
`src/lib/db/migrations/` holds 160 `.sql` files. README.md, AGENTS.md and llm.txt claimed 159, so `check:docs-counts` reported STRICT drift and `tests/unit/check-docs-counts-sync.test.ts` — which asserts the gate exits clean against the current repo state — failed on the release branch. The 42 locale mirrors of llm.txt carried the same number; they are regenerated with `scripts/i18n/sync-llm-mirrors.mjs` rather than edited. Both `check:docs-counts` and `check:docs-sync` now exit 0.
Owner
|
Thanks for catching this — closing in favor of #11502, which already landed the identical fix (README.md, AGENTS.md, and all 42 llm.txt locale mirrors, 159 → 160 migrations) about an hour before this PR was opened. Confirmed on the current release/v3.8.51 tip: all three files already read "160 migrations". No distinct value remains to carry forward — the diffs are byte-identical in substance. Appreciate the independent catch; it's exactly the kind of drift #11502 was meant to close. |
diegosouzapw
pushed a commit
that referenced
this pull request
Aug 25, 2026
Validated in a combined 3-PR batch worktree off release/v3.8.51 tip. The prerequisite sibling (159→160 migrations) was already covered by #11502 — closed the redundant #11543 separately. - New check:docs-counts gate: proven fail-before/pass-after per the PR's own methodology, re-verified here (PASS, 2 unrelated soft-drift notices on cloud-agent/A2A doc counts, non-blocking) - Focused tests: check-docs-counts-sync.test.ts, combo-matrix/auto.test.ts, lkgp-enabled-context-11181.test.ts — pass - typecheck:core, file-size, changelog-integrity, complexity, cognitive-complexity — all OK Thanks for replacing seventeen hand-maintained factor-count claims with one source-derived gate.
Merged
4 of 5 tasks
This was referenced Sep 7, 2026
Merged
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…osouzapw#11545) Validated in a combined 3-PR batch worktree off release/v3.8.51 tip. The prerequisite sibling (159→160 migrations) was already covered by diegosouzapw#11502 — closed the redundant diegosouzapw#11543 separately. - New check:docs-counts gate: proven fail-before/pass-after per the PR's own methodology, re-verified here (PASS, 2 unrelated soft-drift notices on cloud-agent/A2A doc counts, non-blocking) - Focused tests: check-docs-counts-sync.test.ts, combo-matrix/auto.test.ts, lkgp-enabled-context-11181.test.ts — pass - typecheck:core, file-size, changelog-integrity, complexity, cognitive-complexity — all OK Thanks for replacing seventeen hand-maintained factor-count claims with one source-derived gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/lib/db/migrations/holds 160.sqlfiles, but README.md, AGENTS.md and llm.txt claimed 159. This makescheck:docs-countsreport STRICT drift and failstests/unit/check-docs-counts-sync.test.ts, which asserts the gate exits clean against the current tree — so unit tests are currently red on this release base, independent of any in-flight work.scripts/i18n/sync-llm-mirrors.mjsrather than edited by hand.Related Issues
release/v3.8.51.Validation
Note on the lint checkbox: my local node_modules is partially broken (
es-abstractincomplete), so I could not run the fullnpm run lintlocally; nothing in this diff touches linted code. CI is authoritative here.Not applicable: documentation-only change. The existing
tests/unit/check-docs-counts-sync.test.tscovers this area and goes from red to green with this fix.Tests Added Or Updated
Coverage Notes
src/,open-sse/,electron/, orbin/.Reviewer Notes
check:docs-countsandcheck:docs-syncexit 0 after this change (they did not before, on this base).docs/scoring-factor-count,feat/rankings-show-usage-reliability) branch from the same base commit and inherit this pre-existing red test. Merging this one first turns their runs green too.