Repository navigation
chore(release): clear release/v3.8.51 base-red gates — docs count, stryker list, lockfile host, stale suppressions, 7 lint regressions - #11502
Merged
diegosouzapw merged 7 commits intoAug 25, 2026
Conversation
…stryker tap.testFiles, lockfile host, stale suppressions Four mechanical fixes for gates that fail on the pristine release/v3.8.51 tip (tracked in diegosouzapw#11449); none change runtime behaviour. - docs: "159 migrations" → "160" in README.md, AGENTS.md, llm.txt and the 38 strict i18n llm.txt mirrors (check:docs-sync requires byte-identical bodies). - stryker.conf.json: add tests/unit/repro-combo-persisted-cooldown-preskip.test.ts and tests/unit/repro-glm-iso-reset-24h-cap.test.ts to tap.testFiles; they cover mutated modules and check:mutation-test-coverage --strict flags the drift. - package-lock.json: libxmljs2/node_modules/brace-expansion resolved from registry.npmmirror.com → registry.npmjs.org (same tarball, same integrity); check:lockfile only allows the canonical host. - config/quality/eslint-suppressions.json: prune two stale entries (videoBridgeContactSheet.ts, videoBridgeRuntime.ts) that made ESLint exit 2 before reporting anything.
…uning stale suppressions Once the two stale suppression entries are pruned (previous commit), ESLint stops exiting 2 and reports 275 real errors on the base tip — all introduced today: - src/lib/usage/providerLimits.ts: diegosouzapw#11434 removed the callers of windowStillExhaustedAfterRealReset() (added in diegosouzapw#10534) and of three claudeExtraUsage imports but left the definitions behind. Delete the orphaned function and imports; no behaviour change (zero references). - src/lib/guardrails/videoBridge.ts: unused formatVideoTimestamp import (diegosouzapw#11434). - tests/unit/combo-routing-engine.test.ts: the quota-share test added in diegosouzapw#11390 introduced an unused `payload` and two `as any` casts, pushing the file to 269 no-explicit-any against a bulk-suppression quota of 267; ESLint's suppression is all-or-nothing, so every one of the 269 surfaced. `relayOptions` already satisfies ComboRelayOptions (all fields optional), so the cast is dropped and the unused line removed; the file is back at exactly 267. Verification: `npm run lint:json -- --max-warnings 0` exit 0; `npm run typecheck:core` clean; combo-routing-engine.test.ts 91/91; the 12 unit files importing providerLimits/videoBridge 73/73.
…11434 added the two volcengine plans diegosouzapw#11434 added volcengine-agent-plan and volcengine-coding-plan to the regional family without bumping the partition assertion in providers-constants-split.test.ts, which hard-codes the merged count. Actual: 233 keys, 233 distinct, family sum 233.
…rom wsPath.ts; add glm-5.3-max to the GLM test table Two more release/v3.8.51 base-reds (diegosouzapw#11449), both mechanical once traced: - src/shared/utils/wsPath.ts: diegosouzapw#11388 (merged 2026-08-24) fixed diegosouzapw#11331 by adding sanitizeLiveWsPort() + resolveLiveWsUrl() and wiring them into useLiveDashboard.ts with tests/unit/live-ws-url-11331.test.ts. The next day's diegosouzapw#11434 merge carried a competing diegosouzapw#11331 fix (resolveLiveWsPublicUrl) and its wsPath.ts version overwrote diegosouzapw#11388's hunk, while the hook and the test kept importing the two functions. Result on the tip: TS2305 in the hook, the unit test red, and the Turbopack build failing on "Export resolveLiveWsUrl doesn't exist". This re-adds diegosouzapw#11388's two functions verbatim next to the surviving resolveLiveWsPublicUrl; the names do not collide and the precedence they implement (explicit wsUrl → handshake publicUrl → default URL with handshake port/path) is unchanged. - open-sse/mcp-server/__tests__/glmCodingProviderConfig.test.ts: the registry ships glm-5.3-max with a "max" effort tier. Z.AI's GLM-5.3 reference lists reasoning_effort ∈ {low, high, max} and recommends max for coding, so the registry is right and the inventory/tier tables in the test were stale (they already declared ["low","high","max"] on the base model). Verification: tests/unit/live-ws-url-11331.test.ts 11/11; glmCodingProviderConfig 10/10; tsc reports no errors in useLiveDashboard.ts / wsPath.ts.
… as TS2367 on release/v3.8.51 Before diegosouzapw#11436, catalog.ts derived `modelType` as a local `string | undefined` that was only ever assigned "embedding" | "rerank" | "image" | "audio" — "chat" was never produced, and chat models were represented by `undefined`. diegosouzapw#11436 replaced that block with classifyModelSupportedEndpoints(), whose literal return union makes the same comparison a TS2367 (baseline 0 → live 2) and reds check:open-sse-typecheck. `!modelType || modelType === "chat"` is therefore exactly `!modelType`; behaviour is unchanged at both sites. Verification: npm run check:open-sse-typecheck → OK (5 pre-existing errors, all within the frozen baseline); the 8 unit files importing the catalog route 61/61.
diegosouzapw
merged commit Aug 25, 2026
17e4ddf
into
diegosouzapw:release/v3.8.51
12 of 16 checks passed
2 of 4 tasks
diegosouzapw
pushed a commit
that referenced
this pull request
Aug 25, 2026
Validated in a combined 3-PR batch worktree off release/v3.8.51 tip. The prerequisite sibling (159→160 migrations) was already covered by #11502 — closed the redundant #11543 separately. - New check:docs-counts gate: proven fail-before/pass-after per the PR's own methodology, re-verified here (PASS, 2 unrelated soft-drift notices on cloud-agent/A2A doc counts, non-blocking) - Focused tests: check-docs-counts-sync.test.ts, combo-matrix/auto.test.ts, lkgp-enabled-context-11181.test.ts — pass - typecheck:core, file-size, changelog-integrity, complexity, cognitive-complexity — all OK Thanks for replacing seventeen hand-maintained factor-count claims with one source-derived gate.
diegosouzapw
pushed a commit
that referenced
this pull request
Aug 26, 2026
#11484) Validated in a combined sub-batch worktree off release/v3.8.51 tip. Its second commit reimplemented wsPath.ts's sanitizeLiveWsPort/resolveLiveWsUrl to fix a build break it hit — that exact break is already fixed on the current tip via #11502 (the original #11388 implementation restored verbatim). Conflicted against that; resolved by keeping the tip's established implementation and dropping the redundant reimplementation (both are functionally equivalent; the tip's carries the original #11331 doc comments and precedence contract). Pushed the same resolution to this branch. - typecheck:core, file-size, changelog-integrity, complexity, cognitive-complexity — all OK - Full-repo lint: 228 pre-existing dashboard react-hooks/* findings, unrelated to this diff - Focused test: cli-settings-jcode.test.ts (integration) — part of sub-batch's 165/165 run Thanks for the real end-to-end verification (production server, real ~/.jcode/config.toml, jcode --provider-profile omniroute serving a completion, jcode provider-doctor passing) — the managed-block approach (marker-delimited, preserves user-authored config, 409s instead of corrupting on a hand-written conflicting table) is exactly the right shape for this integration.
This was referenced Sep 7, 2026
Merged
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…ryker list, lockfile host, stale suppressions, 7 lint regressions (diegosouzapw#11502) Validated in a combined 4-PR batch worktree off release/v3.8.51 tip. - Every fix individually confirmed against the pristine tip, no runtime behavior change - typecheck:core, file-size, changelog-integrity, complexity, cognitive-complexity, check:cycles — all OK - Full-repo lint: 503 → 228 problems, confirming this PR's diagnosis of the exit-2 stale-suppressions + orphaned-code causes; the remaining 228 are pre-existing dashboard react-hooks/* findings this PR never claimed to touch - node --test tests/unit/combo-routing-engine.test.ts, providers-constants-split.test.ts, and the providerLimits/videoBridge importers — all pass as part of the batch's 246/246 node:test run Thanks for the meticulous base-red triage — this directly explains and fixes the largest lint-drift finding from the prior merge-batch session.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…osouzapw#11545) Validated in a combined 3-PR batch worktree off release/v3.8.51 tip. The prerequisite sibling (159→160 migrations) was already covered by diegosouzapw#11502 — closed the redundant diegosouzapw#11543 separately. - New check:docs-counts gate: proven fail-before/pass-after per the PR's own methodology, re-verified here (PASS, 2 unrelated soft-drift notices on cloud-agent/A2A doc counts, non-blocking) - Focused tests: check-docs-counts-sync.test.ts, combo-matrix/auto.test.ts, lkgp-enabled-context-11181.test.ts — pass - typecheck:core, file-size, changelog-integrity, complexity, cognitive-complexity — all OK Thanks for replacing seventeen hand-maintained factor-count claims with one source-derived gate.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
diegosouzapw#11484) Validated in a combined sub-batch worktree off release/v3.8.51 tip. Its second commit reimplemented wsPath.ts's sanitizeLiveWsPort/resolveLiveWsUrl to fix a build break it hit — that exact break is already fixed on the current tip via diegosouzapw#11502 (the original diegosouzapw#11388 implementation restored verbatim). Conflicted against that; resolved by keeping the tip's established implementation and dropping the redundant reimplementation (both are functionally equivalent; the tip's carries the original diegosouzapw#11331 doc comments and precedence contract). Pushed the same resolution to this branch. - typecheck:core, file-size, changelog-integrity, complexity, cognitive-complexity — all OK - Full-repo lint: 228 pre-existing dashboard react-hooks/* findings, unrelated to this diff - Focused test: cli-settings-jcode.test.ts (integration) — part of sub-batch's 165/165 run Thanks for the real end-to-end verification (production server, real ~/.jcode/config.toml, jcode --provider-profile omniroute serving a completion, jcode provider-doctor passing) — the managed-block approach (marker-delimited, preserves user-authored config, 409s instead of corrupting on a hand-written conflicting table) is exactly the right shape for this integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #11449. Every fix here reproduces on the pristine
release/v3.8.51tip with no other changes, and none alters runtime behaviour.What turns green
check:fabricated-docsstrict drift)llm.txtmirrors (check:docs-syncrequires byte-identical bodies, so root-only edits red it)check:mutation-test-coverage --stricttests/unit/repro-combo-persisted-cooldown-preskip.test.tsandtests/unit/repro-glm-iso-reset-24h-cap.test.tscover mutated modules but are absent fromstryker.conf.jsontap.testFilescheck:lockfilelibxmljs2/node_modules/brace-expansionresolved fromregistry.npmmirror.comregistry.npmjs.org; same tarball, same integrity hashconfig/quality/eslint-suppressions.json(videoBridgeContactSheet.ts,videoBridgeRuntime.ts)eslint --prune-suppressions#11434orphanedwindowStillExhaustedAfterRealReset()+ 3 imports inproviderLimits.tsand 1 import invideoBridge.ts;#11390's new test added an unusedpayloadand twoas any, takingcombo-routing-engine.test.tsto 269 vs a 267 bulk-suppression quota (all-or-nothing → all 269 surface)relayOptionsalready satisfiesComboRelayOptions, cast dropped; file back at exactly 267providers-constants-split.test.tsvolcengine-agent-plan+volcengine-coding-plan(regional) without bumping the hard-coded partition countlive-ws-url-11331.test.tssanitizeLiveWsPort/resolveLiveWsUrltowsPath.tsand wired them intouseLiveDashboard.ts; the next day's #11434 carried a competing #11331 fix whosewsPath.tsoverwrote that hunk while hook + test kept the imports → TS2305, red test, Turbopack "Export resolveLiveWsUrl doesn't exist"resolveLiveWsPublicUrl; 11/11, tsc cleanglmCodingProviderConfig.test.tsglm-5.3-maxwith amaxtier; Z.AI's GLM-5.3 reference documentsreasoning_effort ∈ {low, high, max}(max recommended for coding), so the test's inventory/tier tables were staleglm-5.3-max+["max"]added; 10/10check:open-sse-typecheckcatalog.ts:1614,1648— `!modelTypeVerification (local, this branch)
Deliberately NOT touched (need the owning author's judgement)
6435f618f4and on this PR's tipb4bb5ba8bbwith identical results: 100 tests, 19 failures, the same 19 on both (A2A agent-card skill count ×5, conductor agent-card ×2, provider-nodes CC mode ×2,postExchangeonboarding ×4, openapi coverage floor, route-body Zod t06, pack-artifact closures, hard-lease inventory, translate-path golden, minimax-m3 ledger, Claude/GLM quota recovery ×2). Three names that show only on CI (buildWeeklyQuotaFallback…,checkFallbackError… GLM 429,Antigravity BYOP…) pass locally on both trees — timing flakes, not regressions.Those are listed on #11449 with reproduction notes.