Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node:dnd-drag 增加事件数据 #1916

Merged
merged 2 commits into from
Oct 19, 2024
Merged

fix: node:dnd-drag 增加事件数据 #1916

merged 2 commits into from
Oct 19, 2024

Conversation

HeatonZ
Copy link
Contributor

@HeatonZ HeatonZ commented Oct 17, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 026c62b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ChangeSuger
ChangeSuger approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@ChangeSuger ChangeSuger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没啥问题👍，有余力的话可以再完善一下这个事件相关的类型提示，具体代码是这一行：

LogicFlow/packages/core/src/event/eventArgs.ts

Line 143 in a9a28cf

'node:dnd-drag': NodeEventArgsPick<'data'>

@boyongjiong boyongjiong merged commit 4951343 into didi:master Oct 19, 2024
wbccb added a commit to wbccb/LogicFlow that referenced this pull request Oct 19, 2024
@wbccb
fix(core): 修复因为node:dnd-drag类型缺失导致的运行错误问题(didi#1916)
7081623
wbccb added a commit to wbccb/LogicFlow that referenced this pull request Oct 19, 2024
@wbccb
docs: node:dnd-drag事件增加e的声明(didi#1916)
af2cef7
This was referenced Oct 21, 2024
Merged
Closed
boyongjiong pushed a commit that referenced this pull request Oct 29, 2024
@wbccb @boyongjiong
docs: node:dnd-drag事件增加e的声明(#1916)
89eefcb
menghany pushed a commit to menghany/LogicFlow that referenced this pull request Nov 28, 2024
@wbccb @menghany
docs: node:dnd-drag事件增加e的声明(didi#1916)
0c1e9c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChangeSuger ChangeSuger ChangeSuger approved these changes

@boyongjiong boyongjiong boyongjiong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HeatonZ @boyongjiong @ChangeSuger