Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin torch version #841

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Pin torch version #841

merged 1 commit into from
Aug 14, 2024

Conversation

SarahAlidoost
Copy link
Contributor

@SarahAlidoost SarahAlidoost commented Aug 13, 2024 •
edited
Loading

closes #837
relates #829

@SarahAlidoost SarahAlidoost marked this pull request as ready for review August 13, 2024 12:01
@SarahAlidoost SarahAlidoost mentioned this pull request Aug 13, 2024
Closed
@SarahAlidoost
Copy link
Contributor Author

@cwmeijer I reported the failed tests in #842 which can be fixed in a separate pull request.

cwmeijer
cwmeijer approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cwmeijer cwmeijer merged commit 15f3587 into main Aug 14, 2024
22 of 27 checks passed
@cwmeijer cwmeijer deleted the fix_837 branch August 14, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwmeijer cwmeijer cwmeijer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build action fails due to torchtext OSError --> undefined symbol
2 participants
@SarahAlidoost @cwmeijer